libril: Fix Const-Correctness for

RIL_RadioFunctions

Re-add constant for function pointer table to
RIL_RadioFunctions. Const was accidentally removed
during a warnings cleanup.

Bug: 64231560
Test: compilation
Change-Id: I93675980c51d9162f624495d12fe3c97f1da8031
tirimbino
Nathan Harold 8 years ago committed by Stricted
parent 7d58fd493b
commit ea60787858
No known key found for this signature in database
GPG Key ID: 3E45BB95F7AD33DA
  1. 6
      ril/libril/RilSapSocket.cpp
  2. 8
      ril/libril/RilSapSocket.h
  3. 4
      ril/libril/ril.cpp
  4. 2
      ril/libril/sap_service.cpp
  5. 2
      ril/libril/sap_service.h

@ -112,7 +112,7 @@ RilSapSocket *RilSapSocket::getSocketById(RIL_SOCKET_ID socketId) {
} }
void RilSapSocket::initSapSocket(const char *socketName, void RilSapSocket::initSapSocket(const char *socketName,
RIL_RadioFunctions *uimFuncs) { const RIL_RadioFunctions *uimFuncs) {
if (strcmp(socketName, RIL1_SERVICE_NAME) == 0) { if (strcmp(socketName, RIL1_SERVICE_NAME) == 0) {
if(!SocketExists(socketName)) { if(!SocketExists(socketName)) {
@ -146,7 +146,7 @@ void RilSapSocket::initSapSocket(const char *socketName,
} }
void RilSapSocket::addSocketToList(const char *socketName, RIL_SOCKET_ID socketid, void RilSapSocket::addSocketToList(const char *socketName, RIL_SOCKET_ID socketid,
RIL_RadioFunctions *uimFuncs) { const RIL_RadioFunctions *uimFuncs) {
RilSapSocket* socket = NULL; RilSapSocket* socket = NULL;
RilSapSocketList *current; RilSapSocketList *current;
@ -191,7 +191,7 @@ bool RilSapSocket::SocketExists(const char *socketName) {
RilSapSocket::RilSapSocket(const char *socketName, RilSapSocket::RilSapSocket(const char *socketName,
RIL_SOCKET_ID socketId, RIL_SOCKET_ID socketId,
RIL_RadioFunctions *inputUimFuncs): const RIL_RadioFunctions *inputUimFuncs):
RilSocket(socketName, socketId) { RilSocket(socketName, socketId) {
if (inputUimFuncs) { if (inputUimFuncs) {
uimFuncs = inputUimFuncs; uimFuncs = inputUimFuncs;

@ -39,7 +39,7 @@ class RilSapSocket : public RilSocket {
* Place holder for the radio functions returned by the initialization * Place holder for the radio functions returned by the initialization
* function. Currenty only onRequest handler is being used. * function. Currenty only onRequest handler is being used.
*/ */
RIL_RadioFunctions* uimFuncs; const RIL_RadioFunctions* uimFuncs;
/** /**
* Wrapper struct for handling the requests in the queue. * Wrapper struct for handling the requests in the queue.
@ -69,7 +69,7 @@ class RilSapSocket : public RilSocket {
* @param Radio functions to be used by the socket. * @param Radio functions to be used by the socket.
*/ */
static void initSapSocket(const char *socketName, static void initSapSocket(const char *socketName,
RIL_RadioFunctions *uimFuncs); const RIL_RadioFunctions *uimFuncs);
/** /**
* Ril envoronment variable that holds the request and * Ril envoronment variable that holds the request and
@ -137,7 +137,7 @@ class RilSapSocket : public RilSocket {
* and add socket to the socket list. * and add socket to the socket list.
*/ */
static void addSocketToList(const char *socketName, RIL_SOCKET_ID socketid, static void addSocketToList(const char *socketName, RIL_SOCKET_ID socketid,
RIL_RadioFunctions *uimFuncs); const RIL_RadioFunctions *uimFuncs);
/** /**
* Check if a socket of the given name exists in the socket list. * Check if a socket of the given name exists in the socket list.
@ -157,7 +157,7 @@ class RilSapSocket : public RilSocket {
*/ */
RilSapSocket(const char *socketName, RilSapSocket(const char *socketName,
RIL_SOCKET_ID socketId, RIL_SOCKET_ID socketId,
RIL_RadioFunctions *inputUimFuncs); const RIL_RadioFunctions *inputUimFuncs);
/** /**
* Class method that selects the socket on which the onRequestComplete * Class method that selects the socket on which the onRequestComplete

@ -488,10 +488,10 @@ RIL_register (const RIL_RadioFunctions *callbacks) {
} }
extern "C" void extern "C" void
RIL_register_socket (RIL_RadioFunctions *(*Init)(const struct RIL_Env *, int, char **), RIL_register_socket (const RIL_RadioFunctions *(*Init)(const struct RIL_Env *, int, char **),
RIL_SOCKET_TYPE socketType, int argc, char **argv) { RIL_SOCKET_TYPE socketType, int argc, char **argv) {
RIL_RadioFunctions* UimFuncs = NULL; const RIL_RadioFunctions* UimFuncs = NULL;
if(Init) { if(Init) {
UimFuncs = Init(&RilSapSocket::uimRilEnv, argc, argv); UimFuncs = Init(&RilSapSocket::uimRilEnv, argc, argv);

@ -914,7 +914,7 @@ void sap::processUnsolResponse(MsgHeader *rsp, RilSapSocket *sapSocket) {
processResponse(rsp, sapSocket, MsgType_UNSOL_RESPONSE); processResponse(rsp, sapSocket, MsgType_UNSOL_RESPONSE);
} }
void sap::registerService(RIL_RadioFunctions *callbacks) { void sap::registerService(const RIL_RadioFunctions *callbacks) {
using namespace android::hardware; using namespace android::hardware;
int simCount = 1; int simCount = 1;
const char *serviceNames[] = { const char *serviceNames[] = {

@ -24,7 +24,7 @@
namespace sap { namespace sap {
void registerService(RIL_RadioFunctions *callbacks); void registerService(const RIL_RadioFunctions *callbacks);
void processResponse(MsgHeader *rsp, RilSapSocket *sapSocket); void processResponse(MsgHeader *rsp, RilSapSocket *sapSocket);
void processUnsolResponse(MsgHeader *rsp, RilSapSocket *sapSocket); void processUnsolResponse(MsgHeader *rsp, RilSapSocket *sapSocket);

Loading…
Cancel
Save