Fix macloader buffer overflow

Fixes this log entries.

I/macloader( 1915): Writing murata to /data/.cid.info
D/macloader( 1915): Setting permissions on /data/.cid.info
F/libc    ( 1915): *** vsprintf buffer overflow detected ***
F/libc    ( 1915): Fatal signal 11 (SIGSEGV) at 0xdeadbaad (code=1), thread 1915 (macloader)

Change-Id: I1ccb257bada18030de76a2be40477172993ca2a0
tirimbino
Javier Ferrer 11 years ago
parent cfaad78bbb
commit 76ea68e99b
  1. 4
      macloader/macloader.cpp

@ -117,8 +117,8 @@ int main() {
amode = S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH; amode = S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH;
ret = chmod(CID_PATH, amode); ret = chmod(CID_PATH, amode);
char* chown_cmd = (char*) malloc(strlen("chown system ") + strlen(CID_PATH)); char* chown_cmd = (char*) malloc(strlen("chown system ") + strlen(CID_PATH) + 1);
char* chgrp_cmd = (char*) malloc(strlen("chgrp system ") + strlen(CID_PATH)); char* chgrp_cmd = (char*) malloc(strlen("chgrp system ") + strlen(CID_PATH) + 1);
sprintf(chown_cmd, "chown system %s", CID_PATH); sprintf(chown_cmd, "chown system %s", CID_PATH);
sprintf(chgrp_cmd, "chgrp system %s", CID_PATH); sprintf(chgrp_cmd, "chgrp system %s", CID_PATH);
system(chown_cmd); system(chown_cmd);

Loading…
Cancel
Save