You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Andreas Rohner 70f2fe3a26 nilfs2: fix segctor bug that causes file system corruption ... There is a bug in the function nilfs_segctor_collect, which results in active data being written to a segment, that is marked as clean. It is possible, that this segment is selected for a later segment construction, whereby the old data is overwritten. The problem shows itself with the following kernel log message: nilfs_sufile_do_cancel_free: segment 6533 must be clean Usually a few hours later the file system gets corrupted: NILFS: bad btree node (blocknr=8748107): level = 0, flags = 0x0, nchildren = 0 NILFS error (device sdc1): nilfs_bmap_last_key: broken bmap (inode number=114660) The issue can be reproduced with a file system that is nearly full and with the cleaner running, while some IO intensive task is running. Although it is quite hard to reproduce. This is what happens: 1. The cleaner starts the segment construction 2. nilfs_segctor_collect is called 3. sc_stage is on NILFS_ST_SUFILE and segments are freed 4. sc_stage is on NILFS_ST_DAT current segment is full 5. nilfs_segctor_extend_segments is called, which allocates a new segment 6. The new segment is one of the segments freed in step 3 7. nilfs_sufile_cancel_freev is called and produces an error message 8. Loop around and the collection starts again 9. sc_stage is on NILFS_ST_SUFILE and segments are freed including the newly allocated segment, which will contain active data and can be allocated at a later time 10. A few hours later another segment construction allocates the segment and causes file system corruption This can be prevented by simply reordering the statements. If nilfs_sufile_cancel_freev is called before nilfs_segctor_extend_segments the freed segments are marked as dirty and cannot be allocated any more. Signed-off-by: Andreas Rohner <andreas.rohner@gmx.net> Reviewed-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> Tested-by: Andreas Rohner <andreas.rohner@gmx.net> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		11 years ago
..
Kconfig	fs/nilfs2: remove depends on CONFIG_EXPERIMENTAL	12 years ago
Makefile	…
alloc.c	nilfs2: implement calculation of free inodes count	12 years ago
alloc.h	nilfs2: implement calculation of free inodes count	12 years ago
bmap.c	…
bmap.h	nilfs2: add omitted comments for different structures in driver implementation	13 years ago
btnode.c	…
btnode.h	nilfs2: add omitted comments for different structures in driver implementation	13 years ago
btree.c	…
btree.h	…
cpfile.c	…
cpfile.h	…
dat.c	nilfs2: add omitted comments for different structures in driver implementation	13 years ago
dat.h	…
dir.c	[readdir] convert nilfs2	12 years ago
direct.c	…
direct.h	…
export.h	nilfs2: add omitted comments for different structures in driver implementation	13 years ago
file.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	12 years ago
gcinode.c	…
ifile.c	] nilfs2: use atomic64_t type for inodes_count and blocks_count fields in nilfs_root struct	12 years ago
ifile.h	nilfs2: implement calculation of free inodes count	12 years ago
inode.c	truncate: drop 'oldsize' truncate_pagecache() parameter	12 years ago
ioctl.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	12 years ago
mdt.c	nilfs2: fix issue with flush kernel thread after remount in RO mode because of driver's internal error or metadata corruption	12 years ago
mdt.h	nilfs2: add omitted comments for different structures in driver implementation	13 years ago
namei.c	fs: encode_fh: return FILEID_INVALID if invalid fid_type	12 years ago
nilfs.h	nilfs2: drop vmtruncate	12 years ago
page.c	nilfs2: fix issue with race condition of competition between segments for dirty blocks	12 years ago
page.h	nilfs2: fix issue with flush kernel thread after remount in RO mode because of driver's internal error or metadata corruption	12 years ago
recovery.c	nilfs2: drop vmtruncate	12 years ago
segbuf.c	nilfs2: fix issue with counting number of bio requests for BIO_EOPNOTSUPP error detection	12 years ago
segbuf.h	…
segment.c	nilfs2: fix segctor bug that causes file system corruption	11 years ago
segment.h	…
sufile.c	nilfs2: add omitted comments for different structures in driver implementation	13 years ago
sufile.h	…
super.c	git simplify nilfs check for busy subtree	12 years ago
the_nilfs.c	] nilfs2: use atomic64_t type for inodes_count and blocks_count fields in nilfs_root struct	12 years ago
the_nilfs.h	] nilfs2: use atomic64_t type for inodes_count and blocks_count fields in nilfs_root struct	12 years ago