You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Jeff Kirsher 2d0bb1c1f4 e100/e1000*/igb*/ixgb*: Add missing read memory barrier ... Based on patches from Sonny Rao and Milton Miller... Combined the patches to fix up clean_tx_irq and clean_rx_irq. The PowerPC architecture does not require loads to independent bytes to be ordered without adding an explicit barrier. In ixgbe_clean_rx_irq we load the status bit then load the packet data. With packet split disabled if these loads go out of order we get a stale packet, but we will notice the bad sequence numbers and drop it. The problem occurs with packet split enabled where the TCP/IP header and data are in different descriptors. If the reads go out of order we may have data that doesn't match the TCP/IP header. Since we use hardware checksumming this bad data is never verified and it makes it all the way to the application. This bug was found during stress testing and adding this barrier has been shown to fix it. The bug can manifest as a data integrity issue (bad payload data) or as a BUG in skb_pull(). This was a nasty bug to hunt down, if people agree with the fix I think it's a candidate for stable. Previously Submitted to e1000-devel only for ixgbe http://marc.info/?l=e1000-devel&m=126593062701537&w=3 We've now seen this problem hit with other device drivers (e1000e mostly) So I'm resubmitting with fixes for other Intel Device Drivers with similar issues. CC: Milton Miller <miltonm@bga.com> CC: Anton Blanchard <anton@samba.org> CC: Sonny Rao <sonnyrao@us.ibm.com> CC: stable <stable@kernel.org> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>		15 years ago
..
Makefile	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	15 years ago
ixgbe.h	ixgbe: update set_rx_mode to fix issues w/ macvlan	15 years ago
ixgbe_82598.c	ixgbe:add support for a new 82599 10G Base-T device	15 years ago
ixgbe_82599.c	ixgbe: use netif_<level> instead of netdev_<level>	15 years ago
ixgbe_common.c	ixgbe: return IXGBE_ERR_RAR_INDEX when out of range	15 years ago
ixgbe_common.h	ixgbe: use netif_<level> instead of netdev_<level>	15 years ago
ixgbe_dcb.c	ixgbe: update copyright dates	15 years ago
ixgbe_dcb.h	ixgbe: update copyright dates	15 years ago
ixgbe_dcb_82598.c	ixgbe: update copyright dates	15 years ago
ixgbe_dcb_82598.h	ixgbe: update copyright dates	15 years ago
ixgbe_dcb_82599.c	ixgbe: dcb, set DPF bit when PFC is enabled	15 years ago
ixgbe_dcb_82599.h	ixgbe: update copyright dates	15 years ago
ixgbe_dcb_nl.c	ixgbe: use netif_<level> instead of netdev_<level>	15 years ago
ixgbe_ethtool.c	ixgbe: fix ethtool stats	15 years ago
ixgbe_fcoe.c	ixgbe: use GFP_ATOMIC when allocating FCoE DDP context from the dma pool	15 years ago
ixgbe_fcoe.h	ixgbe: update copyright dates	15 years ago
ixgbe_main.c	e100/e1000*/igb*/ixgb*: Add missing read memory barrier	15 years ago
ixgbe_mbx.c	ixgbe: Mailbox header and code module	15 years ago
ixgbe_mbx.h	ixgbe: Mailbox header and code module	15 years ago
ixgbe_phy.c	ixgbe: add 1g PHY support for 82599	15 years ago
ixgbe_phy.h	ixgbe: add 1g PHY support for 82599	15 years ago
ixgbe_sriov.c	ixgbe: use netif_<level> instead of netdev_<level>	15 years ago
ixgbe_sriov.h	ixgbe: Add support for VF MAC and VLAN configuration	15 years ago
ixgbe_type.h	ixgbe: add 1g PHY support for 82599	15 years ago