You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Jeff Kirsher 2d0bb1c1f4 e100/e1000*/igb*/ixgb*: Add missing read memory barrier ... Based on patches from Sonny Rao and Milton Miller... Combined the patches to fix up clean_tx_irq and clean_rx_irq. The PowerPC architecture does not require loads to independent bytes to be ordered without adding an explicit barrier. In ixgbe_clean_rx_irq we load the status bit then load the packet data. With packet split disabled if these loads go out of order we get a stale packet, but we will notice the bad sequence numbers and drop it. The problem occurs with packet split enabled where the TCP/IP header and data are in different descriptors. If the reads go out of order we may have data that doesn't match the TCP/IP header. Since we use hardware checksumming this bad data is never verified and it makes it all the way to the application. This bug was found during stress testing and adding this barrier has been shown to fix it. The bug can manifest as a data integrity issue (bad payload data) or as a BUG in skb_pull(). This was a nasty bug to hunt down, if people agree with the fix I think it's a candidate for stable. Previously Submitted to e1000-devel only for ixgbe http://marc.info/?l=e1000-devel&m=126593062701537&w=3 We've now seen this problem hit with other device drivers (e1000e mostly) So I'm resubmitting with fixes for other Intel Device Drivers with similar issues. CC: Milton Miller <miltonm@bga.com> CC: Anton Blanchard <anton@samba.org> CC: Sonny Rao <sonnyrao@us.ibm.com> CC: stable <stable@kernel.org> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>		15 years ago
..
82571.c	e1000e: update copyright information	15 years ago
Makefile	e1000e: reformat comment blocks, cosmetic changes only	17 years ago
defines.h	e1000e: update copyright information	15 years ago
e1000.h	e1000e: Fix irq_synchronize in MSI-X case	15 years ago
es2lan.c	e1000e: update copyright information	15 years ago
ethtool.c	e1000e: fail when try to setup unsupported features	15 years ago
hw.h	e1000e: correct MAC-PHY interconnect register offset for 82579	15 years ago
ich8lan.c	e1000e: disable EEE support by default	15 years ago
lib.c	e1000e: update copyright information	15 years ago
netdev.c	e100/e1000*/igb*/ixgb*: Add missing read memory barrier	15 years ago
param.c	e1000e: remove EEE module parameter	15 years ago
phy.c	e1000e: update copyright information	15 years ago