You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Casey Schaufler 57e7ba04d4 lsm: fix smack_inode_removexattr and xattr_getsecurity memleak ... security_inode_getsecurity() provides the text string value of a security attribute. It does not provide a "secctx". The code in xattr_getsecurity() that calls security_inode_getsecurity() and then calls security_release_secctx() happened to work because SElinux and Smack treat the attribute and the secctx the same way. It fails for cap_inode_getsecurity(), because that module has no secctx that ever needs releasing. It turns out that Smack is the one that's doing things wrong by not allocating memory when instructed to do so by the "alloc" parameter. The fix is simple enough. Change the security_release_secctx() to kfree() because it isn't a secctx being returned by security_inode_getsecurity(). Change Smack to allocate the string when told to do so. Note: this also fixes memory leaks for LSMs which implement inode_getsecurity but not release_secctx, such as capabilities. Signed-off-by: Casey Schaufler <casey@schaufler-ca.com> Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Cc: stable@vger.kernel.org Signed-off-by: James Morris <james.l.morris@oracle.com>		7 years ago
..
apparmor	+ Features	7 years ago
integrity	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	8 years ago
keys	security/keys: rewrite all of big_key crypto	7 years ago
loadpin	security: mark LSM hooks as __ro_after_init	8 years ago
selinux	selinux/stable-4.14 PR 20170831	7 years ago
smack	lsm: fix smack_inode_removexattr and xattr_getsecurity memleak	7 years ago
tomoyo	exec: Rename bprm->cred_prepared to called_set_creds	7 years ago
yama	doc: ReSTify Yama.txt	8 years ago
Kconfig	include/linux/string.h: add the option of fortified string.h functions	8 years ago
Makefile	LSM: LoadPin for kernel file loading restrictions	9 years ago
commoncap.c	Merge branch 'next-general' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	7 years ago
device_cgroup.c	…
inode.c	securityfs: add the ability to support symlinks	8 years ago
lsm_audit.c	lsm_audit: update my email address	7 years ago
min_addr.c	…
security.c	selinux/stable-4.14 PR 20170831	7 years ago