You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Linus Torvalds 202c4675c5 pty_write: don't do a tty_wakeup() when the buffers are full ... Commit ac89a9174 ("pty: don't limit the writes to 'pty_space()' inside 'pty_write()'") removed the pty_space() checking, in order to let the regular tty buffer code limit the buffering itself. That was all good, but as a subtle side effect it meant that we'd be doing a tty_wakeup() even in the case where the buffers were all filled up, and didn't actually make any progress on the write. Which sounds innocuous, but it interacts very badly with the ppp_async code, which has an infinite loop in ppp_async_push() that tries to push out data to the tty. When we call tty_wakeup(), that loop ends up thinking that progress was made (see the subtle interactions between XMIT_WAKEUP and 'tty_stuffed' for details). End result: one unhappy ppp user. Fixed by noticing when tty_insert_flip_string() didn't actually do anything, and then not doing any more processing (including, very much not calling tty_wakeup()). Bisected-and-tested-by: Peter Volkov <pva@gentoo.org> Cc: stable@kernel.org (2.6.31) Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		16 years ago
..
agp	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc	16 years ago
hw_random	MIPS: hw_random: Add hardware RNG for Octeon SOCs.	16 years ago
ip2	tty: rewrite the ldisc locking	16 years ago
ipmi	ipmi: remove driver_data direct access of struct device	16 years ago
mwave	mwave: struct device - replace bus_id with dev_name(), dev_set_name()	16 years ago
pcmcia	hdlc: convert to netdev_tx_t	16 years ago
rio	headers: smp_lock.h redux	16 years ago
tpm	TPM: Fixup boot probe timeout for tpm_tis driver	16 years ago
xilinx_hwicap	xilinx_hwicap: remove improper wording in license statement	16 years ago
.gitignore	…
ChangeLog	…
Kconfig	MIPS: Update VR41xx GPIO driver to use gpiolib	16 years ago
Makefile	MIPS: Update VR41xx GPIO driver to use gpiolib	16 years ago
amiserial.c	headers: smp_lock.h redux	16 years ago
apm-emulation.c	APM emulation: Notify about all suspend events, not just APM invoked ones (v2)	17 years ago
applicom.c	applicom: Auto-load applicom module when device opened.	16 years ago
applicom.h	…
bfin-otp.c	…
bfin_jtag_comm.c	bfin_jtag_comm: clean up printk usage	16 years ago
briq_panel.c	briq_panel: BKL pushdown	17 years ago
bsr.c	powerpc/BSR: Fix BSR to allow mmap of small BSR on 64k kernel	16 years ago
cd1865.h	…
consolemap.c	consolemap: indentation & braces disagree - reindent	16 years ago
cp437.uni	unicode table for cp437	16 years ago
cs5535_gpio.c	Add a bunch of cycle_kernel_lock() calls	17 years ago
cyclades.c	headers: smp_lock.h redux	16 years ago
defkeymap.c_shipped	…
defkeymap.map	…
digi1.h	…
digiFep1.h	…
digiPCI.h	…
ds1302.c	rtc: use bcd2bin/bin2bcd	17 years ago
ds1620.c	[ARM] netwinder: clean up GPIO naming	16 years ago
dsp56k.c	device create: char: convert device_create_drvdata to device_create	17 years ago
dtlk.c	dtlk: off by one in {read,write}_tts()	16 years ago
efirtc.c	drivers/char/efirtc.c: removed duplicated #include	17 years ago
epca.c	headers: smp_lock.h redux	16 years ago
epca.h	epca: use tty_port	17 years ago
epcaconfig.h	…
esp.c	esp: fix section mismatch warning	16 years ago
generic_nvram.c	powerpc/nvram: Enable use Generic NVRAM driver for different size chips	16 years ago
generic_serial.c	tty: Remove some pointless casts	16 years ago
genrtc.c	genrtc: BKL pushdown	17 years ago
hangcheck-timer.c	…
hpet.c	irq: change ACPI GSI APIs to also take a device argument	16 years ago
hvc_beat.c	powerpc/cell: Use correct types in beat files	16 years ago
hvc_console.c	hvc_console: Drop unnecessary NULL test	16 years ago
hvc_console.h	powerpc: Make open count variables signed in hvcs/hvsi/hvc_console	16 years ago
hvc_irq.c	hvc_console: Call free_irq() only if request_irq() was successful	16 years ago
hvc_iseries.c	drivers/hvc: Add missing __devexit_p()	16 years ago
hvc_iucv.c	[S390] proper use of device register	16 years ago
hvc_rtas.c	…
hvc_udbg.c	powerpc: udbg-based backend for hvc_console	16 years ago
hvc_vio.c	hvc_console: Add __init and __exit to hvc_vio	16 years ago
hvc_xen.c	hvc_console: Add a hangup notifier for backends	17 years ago
hvcs.c	Merge commit 'origin/master' into next	16 years ago
hvsi.c	powerpc/hvsi: Avoid calculating possibly-invalid address	16 years ago
i8k.c	i8k: Add Dell Vostro systems	16 years ago
isicom.c	headers: smp_lock.h redux	16 years ago
istallion.c	headers: smp_lock.h redux	16 years ago
keyboard.c	Input: keyboard - remove warning about raw mode not supported	16 years ago
lp.c	device create: char: convert device_create_drvdata to device_create	17 years ago
mbcs.c	…
mbcs.h	…
mem.c	mem_class: fix bug	16 years ago
misc.c	Driver Core: misc: add nodename support for misc devices.	16 years ago
mmtimer.c	mmtimer: Push BKL down into the ioctl handler	17 years ago
moxa.c	headers: smp_lock.h redux	16 years ago
moxa.h	…
mspec.c	mspec: convert nopfn to fault	17 years ago
mxser.c	headers: smp_lock.h redux	16 years ago
mxser.h	…
n_hdlc.c	headers: smp_lock.h redux	16 years ago
n_r3964.c	headers: smp_lock.h redux	16 years ago
n_tty.c	n_tty: do O_ONLCR translation as a single write	16 years ago
nozomi.c	tty: fix chars_in_buffers	16 years ago
nsc_gpio.c	…
nvram.c	[PATCH] nvram - convert PRINT_PROC to seq_file	16 years ago
nwbutton.c	…
nwbutton.h	…
nwflash.c	[ARM] netwinder: clean up GPIO naming	16 years ago
pc8736x_gpio.c	pc8736x_gpio: add support for PC87365 chips	17 years ago
ppdev.c	ppdev: reduce kernel log spam	16 years ago
ps3flash.c	ps3flash: Always read chunks of 256 KiB, and cache them	16 years ago
pty.c	pty_write: don't do a tty_wakeup() when the buffers are full	16 years ago
random.c	random: Add optional continuous repetition test to entropy store based rngs	16 years ago
raw.c	vfs: Rename generic_file_aio_write_nolock	16 years ago
riscom8.c	headers: smp_lock.h redux	16 years ago
riscom8.h	tty: add more tty_port fields	17 years ago
riscom8_reg.h	…
rocket.c	headers: smp_lock.h redux	16 years ago
rocket.h	tty: rocketport uses different port flags to everyone else	16 years ago
rocket_int.h	tty: rocketport uses different port flags to everyone else	16 years ago
rtc.c	RTC: Remove the BKL.	16 years ago
scc.h	m68k: atari - Rename "mfp" to "st_mfp"	16 years ago
scx200_gpio.c	Add a bunch of cycle_kernel_lock() calls	17 years ago
selection.c	tty: rewrite the ldisc locking	16 years ago
ser_a2232.c	m68k: ser_a2232 - Kill warn_unused_result warnings	16 years ago
ser_a2232.h	…
ser_a2232fw.ax	…
ser_a2232fw.h	…
serial167.c	cleanup console_print()	16 years ago
snsc.c	device create: char: convert device_create_drvdata to device_create	17 years ago
snsc.h	…
snsc_event.c	…
sonypi.c	Rationalize fasync return values	16 years ago
specialix.c	specialix.c: convert nested spin_lock_irqsave to spin_lock	16 years ago
specialix_io8.h	tty: add more tty_port fields	17 years ago
stallion.c	tty: Add carrier processing on close to the tty_port core	16 years ago
sx.c	headers: smp_lock.h redux	16 years ago
sx.h	…
sxboards.h	…
sxwindow.h	…
synclink.c	hdlc: convert to netdev_tx_t	16 years ago
synclink_gt.c	hdlc: convert to netdev_tx_t	16 years ago
synclinkmp.c	hdlc: convert to netdev_tx_t	16 years ago
sysrq.c	debug lockups: Improve lockup detection, fix generic arch fallback	16 years ago
tb0219.c	Update Yoichi Yuasa's e-mail address	16 years ago
tlclk.c	tlckl: BKL pushdown	17 years ago
toshiba.c	…
tty_audit.c	tty: remove buffer special casing	16 years ago
tty_buffer.c	pty: avoid forcing 'low_latency' tty flag	16 years ago
tty_io.c	tty: fix sanity check	16 years ago
tty_ioctl.c	headers: smp_lock.h redux	16 years ago
tty_ldisc.c	tty: make sure to flush any pending work when halting the ldisc	16 years ago
tty_port.c	tty_port: Fix return on interrupted use	16 years ago
vc_screen.c	vc: create vcs(a) devices for consoles	16 years ago
viotape.c	tape: beyond ARRAY_SIZE of viocd_diskinfo	16 years ago
virtio_console.c	virtio: find_vqs/del_vqs virtio operations	16 years ago
vme_scc.c	m68k: vme_scc - Kill warn_unused_result warnings	16 years ago
vt.c	sparc: Kill PROM console driver.	16 years ago
vt_ioctl.c	headers: smp_lock.h redux	16 years ago