You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Dan Carpenter 7bcc6738ee ISDN: pcbit: off by one bugs in pcbit_set_msn() ... 1) We don't allocate enough space for the NUL terminator so we end up corrupting one character beyond the end of the buffer. 2) The "len - 1" should just be "len". The code is trying to copy a word from a buffer up to a comma or the last word in the buffer. Say you have the buffer, "foo,bar,baz", then this code truncates the last letter off each word so you get "fo", "ba", and "ba". You would hope this kind of bug would get noticed in testing... I'm not very familiar with this code and I can't test it, but I think we should copy the final character. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>		11 years ago
..
Kconfig	…
Makefile	…
callbacks.c	…
callbacks.h	…
capi.c	…
capi.h	…
drv.c	ISDN: pcbit: off by one bugs in pcbit_set_msn()	11 years ago
edss1.c	…
edss1.h	…
layer2.c	isdn: Fix typo in drivers/isdn	12 years ago
layer2.h	…
module.c	…
pcbit.h	…