You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Linus Torvalds de329820e9 ext3: fix broken handling of EXT3_STATE_NEW ... In commit 9df93939b7 ("ext3: Use bitops to read/modify EXT3_I(inode)->i_state") ext3 changed its internal 'i_state' variable to use bitops for its state handling. However, unline the same ext4 change, it didn't actually change the name of the field when it changed the semantics of it. As a result, an old use of 'i_state' remained in fs/ext3/ialloc.c that initialized the field to EXT3_STATE_NEW. And that does not work _at_all_ when we're now working with individually named bits rather than values that get masked. So the code tried to mark the state to be new, but in actual fact set the field to EXT3_STATE_JDATA. Which makes no sense at all, and screws up all the code that checks whether the inode was newly allocated. In particular, it made the xattr code unhappy, and caused various random behavior, like apparently https://bugzilla.redhat.com/show_bug.cgi?id=577911 So fix the initialization, and rename the field to match ext4 so that we don't have this happen again. Cc: James Morris <jmorris@namei.org> Cc: Stephen Smalley <sds@tycho.nsa.gov> Cc: Daniel J Walsh <dwalsh@redhat.com> Cc: Eric Paris <eparis@redhat.com> Cc: Jan Kara <jack@suse.cz> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		15 years ago
..
Kconfig	…
Makefile	…
acl.c	sanitize xattr handler prototypes	15 years ago
acl.h	…
balloc.c	…
bitmap.c	fs: mark nibblemap const	17 years ago
dir.c	…
ext3_jbd.c	…
file.c	…
fsync.c	…
hash.c	…
ialloc.c	ext3: fix broken handling of EXT3_STATE_NEW	15 years ago
inode.c	ext3: fix broken handling of EXT3_STATE_NEW	15 years ago
ioctl.c	…
namei.c	…
namei.h	…
resize.c	…
super.c	…
symlink.c	[PATCH] mark struct inode_operations const 1	18 years ago
xattr.c	dquot: cleanup space allocation / freeing routines	15 years ago
xattr.h	…
xattr_security.c	…
xattr_trusted.c	…
xattr_user.c	…