You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Sebastian Andrzej Siewior 6193d6997c usb: musb: gadget: fix error path ... In case one "forgot" to load the receiver i.e. doing |modprobe omap2430 |modprobe musb_hdrc he ends up with: |musb-hdrc: version 6.0, ?dma?, otg (peripheral+host) |HS USB OTG: no transceiver configured |musb-hdrc musb-hdrc: musb_init_controller failed with status -19 |(NULL device *): gadget not registered. |Unable to handle kernel NULL pointer dereference at virtual address 0000001c |Internal error: Oops: 17 [#1] SMP |[<c011383c>] (sysfs_find_dirent+0x4/0x60) from [<c01138c0>] (sysfs_get_dirent+0x28/0x78) |[<c01138c0>] (sysfs_get_dirent+0x28/0x78) from [<c0115b78>] (sysfs_unmerge_group+0x1c/0x90) |[<c0115b78>] (sysfs_unmerge_group+0x1c/0x90) from [<c0179ba4>] (dpm_sysfs_remove+0x14/0x3c) |[<c0179ba4>] (dpm_sysfs_remove+0x14/0x3c) from [<c01742f8>] (device_del+0x40/0x1b4) |[<c01742f8>] (device_del+0x40/0x1b4) from [<c0174478>] (device_unregister+0xc/0x18) |[<c0174478>] (device_unregister+0xc/0x18) from [<bf0489b4>] (musb_free+0x24/0x88 [musb_hdrc]) |[<bf0489b4>] (musb_free+0x24/0x88 [musb_hdrc]) from [<bf057d18>] (musb_probe+0xb50/0xe3c [musb_hdrc]) |[<bf057d18>] (musb_probe+0xb50/0xe3c [musb_hdrc]) from [<c01779c4>] (platform_drv_probe+0x1c/0x24) The problem is that musb_free() tries to figure out what was initializued and what wasn't and clean up only the initialized part. This works well for usb_del_gadget_udc() but device_unregister() can't deal with it. Therefore we rely on the fact the we always have a parent device and only then remove the device. I broke this in 0f91349 ("usb: gadget: convert all users to the new udc infrastructure") Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Felipe Balbi <balbi@ti.com>		14 years ago
..
Kconfig	usb: musb: fix Kconfig	14 years ago
Makefile	usb: musb: drop a gigantic amount of ifdeferry	14 years ago
am35x.c	usb: musb: drop a gigantic amount of ifdeferry	14 years ago
blackfin.c	usb: musb: blackfin: include prefetch head file	14 years ago
blackfin.h	usb: musb: drop a gigantic amount of ifdeferry	14 years ago
cppi_dma.c	usb: musb: cppi: fix build errors due to DBG and missing musb variable	14 years ago
cppi_dma.h	…
da8xx.c	usb: musb: drop a gigantic amount of ifdeferry	14 years ago
davinci.c	usb: musb: drop a gigantic amount of ifdeferry	14 years ago
davinci.h	…
musb_core.c	Merge branch 'usb-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6	14 years ago
musb_core.h	usb: musb: tusb6010: fix compilation	14 years ago
musb_debug.h	usb: musb: drop unneeded musb_debug trickery	14 years ago
musb_debugfs.c	…
musb_dma.h	…
musb_gadget.c	usb: musb: gadget: fix error path	14 years ago
musb_gadget.h	…
musb_gadget_ep0.c	usb: musb: drop a gigantic amount of ifdeferry	14 years ago
musb_host.c	usb: musb: host: compare status for negative error values	14 years ago
musb_host.h	usb: musb: drop a gigantic amount of ifdeferry	14 years ago
musb_io.h	…
musb_regs.h	usb: musb: tusb6010: fix compilation	14 years ago
musb_virthub.c	usb: musb: drop a gigantic amount of ifdeferry	14 years ago
musbhsdma.c	usb: musb: drop unneeded musb_debug trickery	14 years ago
musbhsdma.h	…
omap2430.c	usb: musb: drop a gigantic amount of ifdeferry	14 years ago
omap2430.h	…
tusb6010.c	usb: musb: tusb6010: fix compilation	14 years ago
tusb6010.h	…
tusb6010_omap.c	usb: musb: tusb6010: fix compilation	14 years ago
ux500.c	usb: musb: ux500: copy dma mask from platform device to musb device	14 years ago
ux500_dma.c	usb: musb: ux500: replace missing DBG with dev_dbg	14 years ago