You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Alex Williamson 4bc94d5dc9 vfio: Fix lockdep issue ... When we open a device file descriptor, we currently have the following: vfio_group_get_device_fd() mutex_lock(&group->device_lock); open() ... if (ret) release() If we hit that error case, we call the backend driver release path, which for vfio-pci looks like this: vfio_pci_release() vfio_pci_disable() vfio_pci_try_bus_reset() vfio_pci_get_devs() vfio_device_get_from_dev() vfio_group_get_device() mutex_lock(&group->device_lock); Whoops, we've stumbled back onto group.device_lock and created a deadlock. There's a low likelihood of ever seeing this play out, but obviously it needs to be fixed. To do that we can use a reference to the vfio_device for vfio_group_get_device_fd() rather than holding the lock. There was a loop in this function, theoretically allowing multiple devices with the same name, but in practice we don't expect such a thing to happen and the code is already aborting from the loop with break on any sort of error rather than continuing and only parsing the first match anyway, so the loop was effectively unused already. Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Fixes: 20f300175a ("vfio/pci: Fix racy vfio_device_get_from_dev() call") Reported-by: Joerg Roedel <joro@8bytes.org> Tested-by: Joerg Roedel <jroedel@suse.de>		10 years ago
..
pci	vfio/pci: Fix racy vfio_device_get_from_dev() call	10 years ago
platform	VFIO: platform: enable ARM64 build	10 years ago
Kconfig	drivers/vfio: Allow type-1 IOMMU instantiation on top of an ARM SMMUv3	10 years ago
Makefile	…
vfio.c	vfio: Fix lockdep issue	10 years ago
vfio_iommu_spapr_tce.c	vfio: powerpc/spapr: Support Dynamic DMA windows	10 years ago
vfio_iommu_type1.c	…
vfio_spapr_eeh.c	drivers/vfio: Support EEH error injection	10 years ago
virqfd.c	…