You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Boaz Harrosh c18c821fd4 nfsd41: Fix a crash when a callback is retried ... If a callback is retried at nfsd4_cb_recall_done() due to some error, the returned rpc reply crashes here: @@ -514,6 +514,7 @@ decode_cb_sequence(struct xdr_stream *xdr, struct nfsd4_cb_sequence *res, u32 dummy; __be32 *p; + BUG_ON(!res); if (res->cbs_minorversion == 0) return 0; [BUG_ON added for demonstration] This is because the nfsd4_cb_done_sequence() has NULLed out the task->tk_msg.rpc_resp pointer. Also eventually the rpc would use the new slot without making sure it is free by calling nfsd41_cb_setup_sequence(). This problem was introduced by a 4.1 protocol addition patch: [0421b5c5] nfsd41: Backchannel: Implement cb_recall over NFSv4.1 Which was overlooking the possibility of an RPC callback retries. For not-4.1 case redoing the _prepare is harmless. Signed-off-by: Boaz Harrosh <bharrosh@panasas.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>		15 years ago
..
Kconfig	…
Makefile	…
auth.c	nfsd: remove pointless paths in file headers	15 years ago
auth.h	…
cache.h	nfsd: remove pointless paths in file headers	15 years ago
export.c	Merge commit 'v2.6.34-rc6'	15 years ago
lockd.c	nfsd: remove pointless paths in file headers	15 years ago
nfs2acl.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
nfs3acl.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
nfs3proc.c	nfsd: minor nfsd read api cleanup	15 years ago
nfs3xdr.c	nfsd: remove pointless paths in file headers	15 years ago
nfs4acl.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
nfs4callback.c	nfsd41: Fix a crash when a callback is retried	15 years ago
nfs4idmap.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
nfs4proc.c	nfsd4: implement reclaim_complete	15 years ago
nfs4recover.c	sanitize vfs_fsync calling conventions	15 years ago
nfs4state.c	gcc-4.6: nfsd: fix initialized but not read warnings	15 years ago
nfs4xdr.c	nfsd: minor nfsd read api cleanup	15 years ago
nfscache.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
nfsctl.c	gcc-4.6: nfsd: fix initialized but not read warnings	15 years ago
nfsd.h	nfsd4: share file descriptors between stateid's	15 years ago
nfsfh.c	nfsd: fix "insecure" export option	15 years ago
nfsfh.h	nfsd: move most of nfsfh.h to fs/nfsd	15 years ago
nfsproc.c	nfsd: minor nfsd read api cleanup	15 years ago
nfssvc.c	nfsd: fix startup/shutdown order bug	15 years ago
nfsxdr.c	nfsd: remove pointless paths in file headers	15 years ago
state.h	nfsd4: share file descriptors between stateid's	15 years ago
stats.c	nfsd: remove pointless paths in file headers	15 years ago
vfs.c	nfsd: minor nfsd read api cleanup	15 years ago
vfs.h	nfsd: minor nfsd read api cleanup	15 years ago
xdr.h	nfsd: remove pointless paths in file headers	15 years ago
xdr3.h	nfsd: remove pointless paths in file headers	15 years ago
xdr4.h	nfsd4: implement reclaim_complete	15 years ago