You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Harvey Harrison 0ecb9529a4 UBIFS: endian handling fixes and annotations ... Noticed by sparse: fs/ubifs/file.c:75:2: warning: restricted __le64 degrades to integer fs/ubifs/file.c:629:4: warning: restricted __le64 degrades to integer fs/ubifs/dir.c:431:3: warning: restricted __le64 degrades to integer This should be checked to ensure the ubifs_assert is working as intended, I've done the suggested annotation in this patch. fs/ubifs/sb.c:298:6: warning: incorrect type in assignment (different base types) fs/ubifs/sb.c:298:6: expected int [signed] [assigned] tmp fs/ubifs/sb.c:298:6: got restricted __le64 [usertype] <noident> fs/ubifs/sb.c:299:19: warning: incorrect type in assignment (different base types) fs/ubifs/sb.c:299:19: expected restricted __le64 [usertype] atime_sec fs/ubifs/sb.c:299:19: got int [signed] [assigned] tmp fs/ubifs/sb.c:300:19: warning: incorrect type in assignment (different base types) fs/ubifs/sb.c:300:19: expected restricted __le64 [usertype] ctime_sec fs/ubifs/sb.c:300:19: got int [signed] [assigned] tmp fs/ubifs/sb.c:301:19: warning: incorrect type in assignment (different base types) fs/ubifs/sb.c:301:19: expected restricted __le64 [usertype] mtime_sec fs/ubifs/sb.c:301:19: got int [signed] [assigned] tmp This looks like a bugfix as your tmp was a u32 so there was truncation in the atime, mtime, ctime value, probably not intentional, add a tmp_le64 and use it here. fs/ubifs/key.h:348:9: warning: cast to restricted __le32 fs/ubifs/key.h:348:9: warning: cast to restricted __le32 fs/ubifs/key.h:419:9: warning: cast to restricted __le32 Read from the annotated union member instead. fs/ubifs/recovery.c:175:13: warning: incorrect type in assignment (different base types) fs/ubifs/recovery.c:175:13: expected unsigned int [unsigned] [usertype] save_flags fs/ubifs/recovery.c:175:13: got restricted __le32 [usertype] flags fs/ubifs/recovery.c:186:13: warning: incorrect type in assignment (different base types) fs/ubifs/recovery.c:186:13: expected restricted __le32 [usertype] flags fs/ubifs/recovery.c:186:13: got unsigned int [unsigned] [usertype] save_flags Do byteshifting at compile time of the flag value. Annotate the saved_flags as le32. fs/ubifs/debug.c:368:10: warning: cast to restricted __le32 fs/ubifs/debug.c:368:10: warning: cast from restricted __le64 Should be checked if the truncation was intentional, I've changed the printk to print the full width. Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>		16 years ago
..
Kconfig	…
Makefile	…
budget.c	UBIFS: add a print, fix comments and more minor stuff	17 years ago
commit.c	UBIFS: remove printk	16 years ago
compress.c	UBIFS: fix ubifs_compress commentary	16 years ago
debug.c	UBIFS: endian handling fixes and annotations	16 years ago
debug.h	UBIFS: add more debugging messages for LPT	17 years ago
dir.c	UBIFS: endian handling fixes and annotations	16 years ago
file.c	UBIFS: endian handling fixes and annotations	16 years ago
find.c	UBIFS: remove unneeded unlikely()	17 years ago
gc.c	UBIFS: improve garbage collection	17 years ago
io.c	UBIFS: check data CRC when in error state	17 years ago
ioctl.c	…
journal.c	UBIFS: xattr bugfixes	17 years ago
key.h	UBIFS: endian handling fixes and annotations	16 years ago
log.c	UBIFS: increment commit number earlier	17 years ago
lprops.c	UBIFS: inline one-line functions	17 years ago
lpt.c	UBIFS: do not read unnecessary bytes when unpacking bits	16 years ago
lpt_commit.c	UBIFS: check buffer length when scanning for LPT nodes	17 years ago
master.c	…
misc.h	UBIFS: inline one-line functions	17 years ago
orphan.c	UBIFS: increment commit number earlier	17 years ago
recovery.c	UBIFS: endian handling fixes and annotations	16 years ago
replay.c	…
sb.c	UBIFS: endian handling fixes and annotations	16 years ago
scan.c	UBIFS: add no_chk_data_crc mount option	17 years ago
shrinker.c	…
super.c	Merge branch 'linux-next' of git://git.infradead.org/ubifs-2.6	16 years ago
tnc.c	UBIFS: correct condition to eliminate unecessary assignment	17 years ago
tnc_commit.c	UBIFS: minor tweaks in commit	17 years ago
tnc_misc.c	UBIFS: correct key comparison	17 years ago
ubifs-media.h	UBIFS: ensure data read beyond i_size is zeroed out correctly	17 years ago
ubifs.h	UBIFS: add more debugging messages for LPT	17 years ago
xattr.c	UBIFS: remove unneeded unlikely()	17 years ago