You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Vivek Goyal da52777000 block: Move blk_throtl_exit() call to blk_cleanup_queue() ... Move blk_throtl_exit() in blk_cleanup_queue() as blk_throtl_exit() is written in such a way that it needs queue lock. In blk_release_queue() there is no gurantee that ->queue_lock is still around. Initially blk_throtl_exit() was in blk_cleanup_queue() but Ingo reported one problem. https://lkml.org/lkml/2010/10/23/86 And a quick fix moved blk_throtl_exit() to blk_release_queue(). commit 7ad58c0286 Author: Jens Axboe <jaxboe@fusionio.com> Date: Sat Oct 23 20:40:26 2010 +0200 block: fix use-after-free bug in blk throttle code This patch reverts above change and does not try to shutdown the throtl work in blk_sync_queue(). By avoiding call to throtl_shutdown_timer_wq() from blk_sync_queue(), we should also avoid the problem reported by Ingo. blk_sync_queue() seems to be used only by md driver and it seems to be using it to make sure q->unplug_fn is not called as md registers its own unplug functions and it is about to free up the data structures used by unplug_fn(). Block throttle does not call back into unplug_fn() or into md. So there is no need to cancel blk throttle work. In fact I think cancelling block throttle work is bad because it might happen that some bios are throttled and scheduled to be dispatched later with the help of pending work and if work is cancelled, these bios might never be dispatched. Block layer also uses blk_sync_queue() during blk_cleanup_queue() and blk_release_queue() time. That should be safe as we are also calling blk_throtl_exit() which should make sure all the throttling related data structures are cleaned up. Signed-off-by: Vivek Goyal <vgoyal@redhat.com> Signed-off-by: Jens Axboe <jaxboe@fusionio.com>		14 years ago
..
Kconfig	kconfig: rename CONFIG_EMBEDDED to CONFIG_EXPERT	14 years ago
Kconfig.iosched	blk-cgroup: config options re-arrangement	15 years ago
Makefile	Merge branch 'for-2.6.37/barrier' of git://git.kernel.dk/linux-2.6-block	14 years ago
blk-cgroup.c	blk-cgroup: Allow creation of hierarchical cgroups	14 years ago
blk-cgroup.h	blkio-throttle: limit max iops value to UINT_MAX	15 years ago
blk-core.c	block: Move blk_throtl_exit() call to blk_cleanup_queue()	14 years ago
blk-exec.c	block: Prevent hang_check firing during long I/O	15 years ago
blk-flush.c	block: reimplement FLUSH/FUA to support merge	14 years ago
blk-integrity.c	block: Fix double free in blk_integrity_unregister	14 years ago
blk-ioc.c	block: Clean up exit_io_context() source code.	14 years ago
blk-iopoll.c	tree-wide: fix assorted typos all over the place	15 years ago
blk-lib.c	block: remove BLKDEV_IFL_WAIT	15 years ago
blk-map.c	block: check for proper length of iov entries earlier in blk_rq_map_user_iov()	14 years ago
blk-merge.c	Merge branch 'for-2.6.38/core' of git://git.kernel.dk/linux-2.6-block	14 years ago
blk-settings.c	block: Initialize ->queue_lock to internal lock at queue allocation time	14 years ago
blk-softirq.c	generic-ipi: remove CSD_FLAG_WAIT	16 years ago
blk-sysfs.c	block: Move blk_throtl_exit() call to blk_cleanup_queue()	14 years ago
blk-tag.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
blk-throttle.c	block: Move blk_throtl_exit() call to blk_cleanup_queue()	14 years ago
blk-timeout.c	block: ensure jiffies wrap is handled correctly in blk_rq_timed_out_timer	15 years ago
blk.h	block: reimplement FLUSH/FUA to support merge	14 years ago
bsg.c	[SCSI] bsg: correct fault if queue object removed while dev_t open	14 years ago
cfq-iosched.c	cfq-iosched: Always provide group isolation.	14 years ago
cfq.h	blk-cgroup: Prepare the base for supporting more than one IO control policies	15 years ago
compat_ioctl.c	BKL: remove extraneous #include <smp_lock.h>	14 years ago
deadline-iosched.c	block: convert to pos and nr_sectors accessors	16 years ago
elevator.c	block: share request flush fields with elevator_private	14 years ago
genhd.c	block/genhd: Change some numerals into macros	14 years ago
ioctl.c	Merge branch 'for-2.6.38/core' of git://git.kernel.dk/linux-2.6-block	14 years ago
noop-iosched.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
scsi_ioctl.c	block: take care not to overflow when calculating total iov length	14 years ago