You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Sasha Levin b67bfe0d42 hlist: drop the node parameter from iterators ... I'm not sure why, but the hlist for each entry iterators were conceived list_for_each_entry(pos, head, member) The hlist ones were greedy and wanted an extra parameter: hlist_for_each_entry(tpos, pos, head, member) Why did they need an extra pos parameter? I'm not quite sure. Not only they don't really need it, it also prevents the iterator from looking exactly like the list iterator, which is unfortunate. Besides the semantic patch, there was some manual work required: - Fix up the actual hlist iterators in linux/list.h - Fix up the declaration of other iterators based on the hlist ones. - A very small amount of places were using the 'node' parameter, this was modified to use 'obj->member' instead. - Coccinelle didn't handle the hlist_for_each_entry_safe iterator properly, so those had to be fixed up manually. The semantic patch which is mostly the work of Peter Senna Tschudin is here: @@ iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host; type T; expression a,c,d,e; identifier b; statement S; @@ -T b; <+... when != b ( hlist_for_each_entry(a, - b, c, d) S | hlist_for_each_entry_continue(a, - b, c) S | hlist_for_each_entry_from(a, - b, c) S | hlist_for_each_entry_rcu(a, - b, c, d) S | hlist_for_each_entry_rcu_bh(a, - b, c, d) S | hlist_for_each_entry_continue_rcu_bh(a, - b, c) S | for_each_busy_worker(a, c, - b, d) S | ax25_uid_for_each(a, - b, c) S | ax25_for_each(a, - b, c) S | inet_bind_bucket_for_each(a, - b, c) S | sctp_for_each_hentry(a, - b, c) S | sk_for_each(a, - b, c) S | sk_for_each_rcu(a, - b, c) S | sk_for_each_from -(a, b) +(a) S + sk_for_each_from(a) S | sk_for_each_safe(a, - b, c, d) S | sk_for_each_bound(a, - b, c) S | hlist_for_each_entry_safe(a, - b, c, d, e) S | hlist_for_each_entry_continue_rcu(a, - b, c) S | nr_neigh_for_each(a, - b, c) S | nr_neigh_for_each_safe(a, - b, c, d) S | nr_node_for_each(a, - b, c) S | nr_node_for_each_safe(a, - b, c, d) S | - for_each_gfn_sp(a, c, d, b) S + for_each_gfn_sp(a, c, d) S | - for_each_gfn_indirect_valid_sp(a, c, d, b) S + for_each_gfn_indirect_valid_sp(a, c, d) S | for_each_host(a, - b, c) S | for_each_host_safe(a, - b, c, d) S | for_each_mesh_entry(a, - b, c, d) S ) ...+> [akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c] [akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c] [akpm@linux-foundation.org: checkpatch fixes] [akpm@linux-foundation.org: fix warnings] [akpm@linux-foudnation.org: redo intrusive kvm changes] Tested-by: Peter Senna Tschudin <peter.senna@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Sasha Levin <sasha.levin@oracle.com> Cc: Wu Fengguang <fengguang.wu@intel.com> Cc: Marcelo Tosatti <mtosatti@redhat.com> Cc: Gleb Natapov <gleb@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		12 years ago
..
Kconfig	fs/xfs: remove depends on CONFIG_EXPERIMENTAL	12 years ago
Makefile	xfs: remove xfs_flushinval_pages	12 years ago
kmem.c	xfs: switch to proper __bitwise type for KM_... flags	13 years ago
kmem.h	xfs: switch to proper __bitwise type for KM_... flags	13 years ago
mrlock.h	xfs: remove subdirectories	14 years ago
time.h	xfs: remove subdirectories	14 years ago
uuid.c	xfs: remove subdirectories	14 years ago
uuid.h	xfs: add CRC infrastructure	12 years ago
xfs.h	xfs: don't expect xfs headers to be in subdirectories	14 years ago
xfs_acl.c	userns: Pass a userns parameter into posix_acl_to_xattr and posix_acl_from_xattr	13 years ago
xfs_acl.h	xfs: Fix build breakage in xfs_iops.c when CONFIG_FS_POSIX_ACL is not set	14 years ago
xfs_ag.h	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_alloc.c	xfs: don't zero structure members after a memset(0)	12 years ago
xfs_alloc.h	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_alloc_btree.c	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_alloc_btree.h	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_aops.c	xfs: Fix possible use-after-free with AIO	12 years ago
xfs_aops.h	Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision.	13 years ago
xfs_attr.c	xfs: refactor space log reservation for XFS_TRANS_ATTR_SET	12 years ago
xfs_attr.h	…
xfs_attr_leaf.c	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_attr_leaf.h	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_attr_sf.h	…
xfs_bit.c	…
xfs_bit.h	…
xfs_bmap.c	xfs: xfs_bmap_add_attrfork_local is too generic	12 years ago
xfs_bmap.h	xfs: move allocation stack switch up to xfs_bmapi_allocate	13 years ago
xfs_bmap_btree.c	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_bmap_btree.h	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_btree.c	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_btree.h	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_buf.c	xfs: remove log force from xfs_buf_trylock()	12 years ago
xfs_buf.h	xfs: use b_maps[] for discontiguous buffers	12 years ago
xfs_buf_item.c	xfs: recheck buffer pinned status after push trylock failure	12 years ago
xfs_buf_item.h	xfs: rename bli_format to avoid confusion with bli_formats	12 years ago
xfs_cksum.h	xfs: add CRC infrastructure	12 years ago
xfs_da_btree.c	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_da_btree.h	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_dfrag.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	12 years ago
xfs_dfrag.h	…
xfs_dinode.h	xfs: fix typo in comment of xfs_dinode_t.	13 years ago
xfs_dir2.c	xfs: remove struct xfs_dabuf and infrastructure	13 years ago
xfs_dir2.h	xfs: reshuffle dir2 headers	14 years ago
xfs_dir2_block.c	xfs: recalculate leaf entry pointer after compacting a dir2 block	12 years ago
xfs_dir2_data.c	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_dir2_format.h	xfs: cleanup struct xfs_dir2_free	14 years ago
xfs_dir2_leaf.c	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_dir2_node.c	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_dir2_priv.h	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_dir2_sf.c	xfs: remove struct xfs_dabuf and infrastructure	13 years ago
xfs_discard.c	xfs: check for possible overflow in xfs_ioc_trim	13 years ago
xfs_discard.h	xfs: remove subdirectories	14 years ago
xfs_dquot.c	xfs: calculate XFS_TRANS_QM_DQALLOC space log reservation at mount time	12 years ago
xfs_dquot.h	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_dquot_item.c	xfs: clean up xfs_bit.h includes	13 years ago
xfs_dquot_item.h	xfs: remove subdirectories	14 years ago
xfs_error.c	xfs: move xfsagino_t to xfs_types.h	13 years ago
xfs_error.h	xfs: kill support/debug.[ch]	14 years ago
xfs_export.c	fs: encode_fh: return FILEID_INVALID if invalid fid_type	12 years ago
xfs_export.h	xfs: remove subdirectories	14 years ago
xfs_extent_busy.c	xfs: make xfs_extent_busy_trim not static	13 years ago
xfs_extent_busy.h	xfs: make xfs_extent_busy_trim not static	13 years ago
xfs_extfree_item.c	xfs: move xfsagino_t to xfs_types.h	13 years ago
xfs_extfree_item.h	xfs: Pull EFI/EFD handling out from under the AIL lock	14 years ago
xfs_file.c	new helper: file_inode(file)	12 years ago
xfs_filestream.c	xfs: rename allocation range fields in struct xfs_bmalloca	14 years ago
xfs_filestream.h	…
xfs_fs.h	xfs: add minimum file size filtering to eofblocks scan	12 years ago
xfs_fsops.c	xfs: make use of XFS_SB_LOG_RES() at xfs_fs_log_dummy()	12 years ago
xfs_fsops.h	xfs: ensure log covering transactions are synchronous	14 years ago
xfs_globals.c	xfs: add background scanning to clear eofblocks inodes	12 years ago
xfs_ialloc.c	xfs: don't zero structure members after a memset(0)	12 years ago
xfs_ialloc.h	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_ialloc_btree.c	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_ialloc_btree.h	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_icache.c	xfs: add background scanning to clear eofblocks inodes	12 years ago
xfs_icache.h	xfs: add background scanning to clear eofblocks inodes	12 years ago
xfs_inode.c	xfs remove the XFS_TRANS_DEBUG routines	12 years ago
xfs_inode.h	xfs: memory barrier before wake_up_bit()	12 years ago
xfs_inode_item.c	xfs remove the XFS_TRANS_DEBUG routines	12 years ago
xfs_inode_item.h	xfs remove the XFS_TRANS_DEBUG routines	12 years ago
xfs_inum.h	xfs: move xfsagino_t to xfs_types.h	13 years ago
xfs_ioctl.c	new helper: file_inode(file)	12 years ago
xfs_ioctl.h	xfs: remove subdirectories	14 years ago
xfs_ioctl32.c	new helper: file_inode(file)	12 years ago
xfs_ioctl32.h	xfs: remove subdirectories	14 years ago
xfs_iomap.c	xfs: limit speculative prealloc size on sparse files	12 years ago
xfs_iomap.h	xfs: kill xfs_iomap	14 years ago
xfs_iops.c	xfs: remove xfs_flush_pages	12 years ago
xfs_iops.h	xfs: remove subdirectories	14 years ago
xfs_itable.c	xfs: convert buffer verifiers to an ops structure.	12 years ago
xfs_itable.h	…
xfs_linux.h	xfs: add CRC infrastructure	12 years ago
xfs_log.c	xfs: fix fs/xfs/xfs_log.c:1740:39: error: 'B_TRUE' undeclared	12 years ago
xfs_log.h	xfs: xfs_quiesce_attr() should quiesce the log like unmount	13 years ago
xfs_log_cil.c	xfs: rename log structure to xlog	13 years ago
xfs_log_priv.h	xfs: fix sparse reported log CRC endian issue	12 years ago
xfs_log_recover.c	hlist: drop the node parameter from iterators	12 years ago
xfs_log_recover.h	…
xfs_message.c	xfs: move xfsagino_t to xfs_types.h	13 years ago
xfs_message.h	treewide: use __printf not __attribute__((format(printf,...)))	13 years ago
xfs_mount.c	xfs: make use of XFS_SB_LOG_RES() at xfs_mount_log_sb()	12 years ago
xfs_mount.h	xfs: refactor space log reservation for XFS_TRANS_ATTR_SET	12 years ago
xfs_mru_cache.c	xfs: convert to alloc_workqueue()	14 years ago
xfs_mru_cache.h	…
xfs_qm.c	xfs: calculate xfs_qm_write_sb_changes() space log reservation at mount time	12 years ago
xfs_qm.h	xfs: remove the global xfs_Gqm structure	13 years ago
xfs_qm_bhv.c	xfs: Remove boolean_t typedef completely.	12 years ago
xfs_qm_syscalls.c	xfs: calculate XFS_TRANS_QM_QUOTAOFF_END space log reservation at mount time	12 years ago
xfs_quota.h	Define new macro XFS_ALL_QUOTA_ACTIVE and simply some usage	13 years ago
xfs_quota_priv.h	xfs: use per-filesystem radix trees for dquot lookup	13 years ago
xfs_quotaops.c	userns: Convert qutoactl	13 years ago
xfs_rename.c	xfs: move xfsagino_t to xfs_types.h	13 years ago
xfs_rtalloc.c	xfs: uncached buffer reads need to return an error	12 years ago
xfs_rtalloc.h	xfs: Remove the macro XFS_BUF_PTR	14 years ago
xfs_sb.h	xfs: add CRC infrastructure	12 years ago
xfs_stats.c	xfs: use common code for quota statistics	13 years ago
xfs_stats.h	xfs: use common code for quota statistics	13 years ago
xfs_super.c	fs/xfs remove obsolete simple_strto<foo>	12 years ago
xfs_super.h	xfs: xfs_sync_data is redundant.	13 years ago
xfs_sysctl.c	xfs: add background scanning to clear eofblocks inodes	12 years ago
xfs_sysctl.h	xfs: add background scanning to clear eofblocks inodes	12 years ago
xfs_trace.c	xfs: clean up xfs_bit.h includes	13 years ago
xfs_trace.h	xfs: fix shutdown hang on invalid inode during create	12 years ago
xfs_trans.c	xfs: refactor space log reservation for XFS_TRANS_ATTR_SET	12 years ago
xfs_trans.h	xfs: refactor space log reservation for XFS_TRANS_ATTR_SET	12 years ago
xfs_trans_ail.c	xfs remove the XFS_TRANS_DEBUG routines	12 years ago
xfs_trans_buf.c	xfs: fix the multi-segment log buffer format	12 years ago
xfs_trans_dquot.c	xfs: Remove boolean_t typedef completely.	12 years ago
xfs_trans_extfree.c	xfs: move xfsagino_t to xfs_types.h	13 years ago
xfs_trans_inode.c	xfs remove the XFS_TRANS_DEBUG routines	12 years ago
xfs_trans_priv.h	xfs: re-enable xfsaild idle mode and fix associated races	13 years ago
xfs_trans_space.h	…
xfs_types.h	xfs: Remove boolean_t typedef completely.	12 years ago
xfs_utils.c	xfs: remove the alloc_done argument to xfs_dialloc	13 years ago
xfs_utils.h	xfs: propagate umode_t	13 years ago
xfs_vnode.h	xfs: remove remaining scraps of struct xfs_iomap	13 years ago
xfs_vnodeops.c	xfs: Remove boolean_t typedef completely.	12 years ago
xfs_vnodeops.h	xfs: byte range granularity for XFS_IOC_ZERO_RANGE	12 years ago
xfs_xattr.c	xfs: remove subdirectories	14 years ago