You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Eric Paris 76f7ba35d4 SELinux: shrink sizeof av_inhert selinux_class_perm and context ... I started playing with pahole today and decided to put it against the selinux structures. Found we could save a little bit of space on x86_64 (and no harm on i686) just reorganizing some structs. Object size changes: av_inherit: 24 -> 16 selinux_class_perm: 48 -> 40 context: 80 -> 72 Admittedly there aren't many of av_inherit or selinux_class_perm's in the kernel (33 and 1 respectively) But the change to the size of struct context reverberate out a bit. I can get some hard number if they are needed, but I don't see why they would be. We do change which cacheline context->len and context->str would be on, but I don't see that as a problem since we are clearly going to have to load both if the context is to be of any value. I've run with the patch and don't seem to be having any problems. An example of what's going on using struct av_inherit would be: form: to: struct av_inherit { struct av_inherit { u16 tclass; const char **common_pts; const char **common_pts; u32 common_base; u32 common_base; u16 tclass; }; (notice all I did was move u16 tclass to the end of the struct instead of the beginning) Memory layout before the change: struct av_inherit { u16 tclass; /* 2 */ /* 6 bytes hole */ const char** common_pts; /* 8 */ u32 common_base; /* 4 */ /* 4 byes padding */ /* size: 24, cachelines: 1 */ /* sum members: 14, holes: 1, sum holes: 6 */ /* padding: 4 */ }; Memory layout after the change: struct av_inherit { const char ** common_pts; /* 8 */ u32 common_base; /* 4 */ u16 tclass; /* 2 */ /* 2 bytes padding */ /* size: 16, cachelines: 1 */ /* sum members: 14, holes: 0, sum holes: 0 */ /* padding: 2 */ }; Signed-off-by: Eric Paris <eparis@redhat.com> Signed-off-by: James Morris <jmorris@namei.org>		16 years ago
..
audit.h	…
av_inherit.h	…
av_perm_to_string.h	CRED: Add a kernel_service object class to SELinux	16 years ago
av_permissions.h	CRED: Add a kernel_service object class to SELinux	16 years ago
avc.h	SELinux: add boundary support and thread context assignment	17 years ago
avc_ss.h	SELinux: shrink sizeof av_inhert selinux_class_perm and context	16 years ago
class_to_string.h	CRED: Add a kernel_service object class to SELinux	16 years ago
common_perm_to_string.h	…
conditional.h	…
flask.h	CRED: Add a kernel_service object class to SELinux	16 years ago
initial_sid_to_string.h	…
netif.h	…
netlabel.h	selinux: Cache NetLabel secattrs in the socket's security struct	17 years ago
netnode.h	…
netport.h	…
objsec.h	CRED: Make execve() take advantage of copy-on-write credentials	16 years ago
security.h	SELinux: add boundary support and thread context assignment	17 years ago
xfrm.h	…