You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tejun Heo 5a0e3ad6af include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h ... percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>		15 years ago
..
Kconfig	PCI: push deprecated pci_find_device() function to last user	15 years ago
Makefile	ISDN: Make isdnhdlc usable for other ISDN drivers	16 years ago
amd7930_fn.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
amd7930_fn.h	…
arcofi.c	headers: remove sched.h from interrupt.h	16 years ago
arcofi.h	…
asuscom.c	isdn: replace remaining __FUNCTION__ occurrences	17 years ago
avm_a1.c	[ISDN] Hisax: eliminate many unnecessary references to CardType[]	17 years ago
avm_a1p.c	isdn: fix section mismatch warning for ISACVer	17 years ago
avm_pci.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
avma1_cs.c	isdn: Cleanup Sections in PCMCIA driver avma1	15 years ago
bkm_a4t.c	PCI: push deprecated pci_find_device() function to last user	15 years ago
bkm_a8.c	PCI: push deprecated pci_find_device() function to last user	15 years ago
bkm_ax.h	…
callc.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
config.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
diva.c	PCI: push deprecated pci_find_device() function to last user	15 years ago
elsa.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
elsa_cs.c	isdn: Cleanup Sections in PCMCIA driver elsa	15 years ago
elsa_ser.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
enternow_pci.c	PCI: push deprecated pci_find_device() function to last user	15 years ago
fsm.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
fsm.h	…
gazel.c	PCI: push deprecated pci_find_device() function to last user	15 years ago
hfc4s8s_l1.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
hfc4s8s_l1.h	Fix misc .c/.h comment typos	18 years ago
hfc_2bds0.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
hfc_2bds0.h	…
hfc_2bs0.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
hfc_2bs0.h	…
hfc_pci.c	PCI: push deprecated pci_find_device() function to last user	15 years ago
hfc_pci.h	…
hfc_sx.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
hfc_sx.h	…
hfc_usb.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
hfc_usb.h	hisax: update hfc_usb driver	18 years ago
hfcscard.c	drivers/isdn/hisax: fix sparse warning: Should it be static?	16 years ago
hisax.h	PCI: push deprecated pci_find_device() function to last user	15 years ago
hisax_cfg.h	[ISDN] HiSax: modularization prep	17 years ago
hisax_debug.h	isdn: replace remaining __FUNCTION__ occurrences	17 years ago
hisax_fcpcipnp.c	pnp: fix the fcpnp_driver declaration to only exist if CONFIG_PNP=y	17 years ago
hisax_fcpcipnp.h	…
hisax_if.h	long vs. unsigned long - low-hanging fruits in drivers	18 years ago
hisax_isac.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
hisax_isac.h	…
hscx.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
hscx.h	…
hscx_irq.c	isdn: hisax: Fix test in waitforxfw	15 years ago
icc.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
icc.h	…
ipac.h	…
ipacx.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
ipacx.h	…
isac.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
isac.h	…
isar.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
isar.h	…
isdnl1.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
isdnl1.h	[PATCH] drivers/isdn/hisax/: proper prototypes	18 years ago
isdnl2.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
isdnl2.h	…
isdnl3.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
isdnl3.h	[PATCH] drivers/isdn/hisax/: proper prototypes	18 years ago
isurf.c	[ISDN] Hisax: eliminate many unnecessary references to CardType[]	17 years ago
ix1_micro.c	isdn: replace remaining __FUNCTION__ occurrences	17 years ago
jade.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
jade.h	…
jade_irq.c	…
l3_1tr6.c	ISDN: ARRAY_SIZE changes	16 years ago
l3_1tr6.h	…
l3dss1.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
l3dss1.h	…
l3ni1.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
l3ni1.h	…
lmgr.c	…
mic.c	[ISDN] Hisax: eliminate many unnecessary references to CardType[]	17 years ago
netjet.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
netjet.h	[ISDN] Hisax: eliminate many unnecessary references to CardType[]	17 years ago
niccy.c	PCI: push deprecated pci_find_device() function to last user	15 years ago
nj_s.c	PCI: push deprecated pci_find_device() function to last user	15 years ago
nj_u.c	PCI: push deprecated pci_find_device() function to last user	15 years ago
q931.c	ISDN: ARRAY_SIZE changes	16 years ago
s0box.c	[ISDN] Hisax: eliminate many unnecessary references to CardType[]	17 years ago
saphir.c	[ISDN] Hisax: eliminate many unnecessary references to CardType[]	17 years ago
sedlbauer.c	PCI: push deprecated pci_find_device() function to last user	15 years ago
sedlbauer_cs.c	isdn: Cleanup Sections in PCMCIA driver sedlbauer	15 years ago
sportster.c	[ISDN] Hisax: eliminate many unnecessary references to CardType[]	17 years ago
st5481.h	ISDN: Make isdnhdlc usable for other ISDN drivers	16 years ago
st5481_b.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
st5481_d.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
st5481_init.c	HiSax: fix error checking for hisax_register()]	18 years ago
st5481_usb.c	ISDN: Add support for none reverse bitstreams to isdnhdc	16 years ago
tei.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
teleint.c	[ISDN] Hisax: eliminate many unnecessary references to CardType[]	17 years ago
teles0.c	drivers/isdn/hisax: fix sparse warning: Should it be static?	16 years ago
teles3.c	drivers/isdn/hisax: fix sparse warning: Should it be static?	16 years ago
teles_cs.c	isdn: Cleanup Sections in PCMCIA driver teles	15 years ago
telespci.c	PCI: push deprecated pci_find_device() function to last user	15 years ago
w6692.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
w6692.h	…