You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Arnaldo Carvalho de Melo a9948a7e15 [TCP]: Fix minisock tcp_create_openreq_child() typo. ... On 2/28/07, KOVACS Krisztian <hidden@balabit.hu> wrote: > > Hi, > > While reading TCP minisock code I've found this suspiciously looking > code fragment: > > - 8< - > struct sock *tcp_create_openreq_child(struct sock *sk, struct request_sock *req, struct sk_buff *skb) > { > struct sock *newsk = inet_csk_clone(sk, req, GFP_ATOMIC); > > if (newsk != NULL) { > const struct inet_request_sock *ireq = inet_rsk(req); > struct tcp_request_sock *treq = tcp_rsk(req); > struct inet_connection_sock *newicsk = inet_csk(sk); > struct tcp_sock *newtp; > - 8< - > > The above code initializes newicsk to inet_csk(sk), isn't that supposed > to be inet_csk(newsk)? As far as I can tell this might leave > icsk_ack.last_seg_size zero even if we do have received data. Good catch! David, please apply the attached patch. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>		18 years ago
..
802	[PATCH] remove many unneeded #includes of sched.h	18 years ago
8021q	[PATCH] mark struct file_operations const 7	18 years ago
appletalk	[PATCH] sysctl: remove insert_at_head from register_sysctl	18 years ago
atm	[PATCH] remove many unneeded #includes of sched.h	18 years ago
ax25	[PATCH] sysctl: remove insert_at_head from register_sysctl	18 years ago
bluetooth	[Bluetooth] Make use of device_move() for RFCOMM TTY devices	18 years ago
bridge	[BRIDGE]: Fix locking of set path cost.	18 years ago
core	[NET]: Fix kfree(skb)	18 years ago
dccp	[NET]: Fix kfree(skb)	18 years ago
decnet	[PATCH] sysctl: remove the proc_dir_entry member for the sysctl tables	18 years ago
econet	[PATCH] remove many unneeded #includes of sched.h	18 years ago
ethernet	[PATCH] remove many unneeded #includes of sched.h	18 years ago
ieee80211	Merge branch 'upstream' into upstream-jgarzik	18 years ago
ipv4	[TCP]: Fix minisock tcp_create_openreq_child() typo.	18 years ago
ipv6	[IPV6]: /proc/net/anycast6 unbalanced inet6_dev refcnt	18 years ago
ipx	[IPX]: Remove ancient changelog	18 years ago
irda	[IRDA] net/irda/: proper prototypes	18 years ago
iucv	[S390]: Add AF_IUCV socket support	18 years ago
key	[XFRM]: Fix OOPSes in xfrm_audit_log().	18 years ago
lapb	[PATCH] remove many unneeded #includes of sched.h	18 years ago
llc	[PATCH] sysctl: remove insert_at_head from register_sysctl	18 years ago
netfilter	[NET]: Handle disabled preemption in gfp_any()	18 years ago
netlabel	[NET]: Fix kfree(skb)	18 years ago
netlink	[PATCH] mark struct file_operations const 8	18 years ago
netrom	[PATCH] sysctl: remove insert_at_head from register_sysctl	18 years ago
packet	[AF_PACKET]: Remove unnecessary casts.	18 years ago
rose	[PATCH] sysctl: remove insert_at_head from register_sysctl	18 years ago
rxrpc	[PATCH] sysctl: remove insert_at_head from register_sysctl	18 years ago
sched	[PATCH] remove many unneeded #includes of sched.h	18 years ago
sctp	[SCTP]: Strike the transport before updating rto.	18 years ago
sunrpc	[PATCH] Convert highest_possible_processor_id to nr_cpu_ids	18 years ago
tipc	[NET] TIPC: Fix whitespace errors.	18 years ago
unix	[PATCH] sysctl: remove insert_at_head from register_sysctl	18 years ago
wanrouter	[PATCH] mark struct file_operations const 8	18 years ago
x25	[PATCH] sysctl: remove insert_at_head from register_sysctl	18 years ago
xfrm	[NET]: Fix kfree(skb)	18 years ago
Kconfig	[S390]: Rewrite of the IUCV base code, part 2	18 years ago
Makefile	[S390]: Rewrite of the IUCV base code, part 2	18 years ago
TUNABLE	…
compat.c	[PATCH] remove many unneeded #includes of sched.h	18 years ago
nonet.c	…
socket.c	[PATCH] AUDIT_FD_PAIR	18 years ago
sysctl_net.c	Remove obsolete #include <linux/config.h>	19 years ago