You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

OGAWA Hirofumi 8d1c481960 [PATCH] arch/i386/pci/mmconfig.c tlb flush fix ... We use the fixmap for accessing pci config space in pci_mmcfg_read/write(). The problem is in pci_exp_set_dev_base(). It is caching a last accessed address to avoid calling set_fixmap_nocache() whenever pci_mmcfg_read/write() is used. static inline void pci_exp_set_dev_base(int bus, int devfn) { u32 dev_base = base | (bus << 20) | (devfn << 12); if (dev_base != mmcfg_last_accessed_device) { mmcfg_last_accessed_device = dev_base; set_fixmap_nocache(FIX_PCIE_MCFG, dev_base); } } cpu0 cpu1 --------------------------------------------------------------------------- pci_mmcfg_read("device-A") pci_exp_set_dev_base() set_fixmap_nocache() pci_mmcfg_read("device-B") pci_exp_set_dev_base() set_fixmap_nocache() pci_mmcfg_read("device-B") pci_exp_set_dev_base() /* doesn't flush tlb */ But if cpus accessed the above order, the second pci_mmcfg_read() on cpu0 doesn't flush the TLB, because "mmcfg_last_accessed_device" is device-B. So, second pci_mmcfg_read() on cpu0 accesses a device-A via a previous TLB cache. This problem became the cause of several strange behavior. This patches fixes this situation by adds "mmcfg_last_accessed_cpu" check. [ Alternatively, we could make a per-cpu mapping area or something. Not that it's probably worth it, but if we wanted to avoid all locking and instead just disable preemption, that would be the way to go. --Linus ] Signed-off-by: OGAWA Hirofumi <hogawa@miraclelinux.com> Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> Signed-off-by: Linus Torvalds <torvalds@osdl.org>		18 years ago
..
Makefile	[PATCH] x86: Move direct PCI scanning functions out of line	19 years ago
acpi.c	[PATCH] PCI: arch/i386/pci/acpi.c: use for_each_pci_dev	19 years ago
common.c	PCI: make arch/i386/pci/common.c:pci_bf_sort static	18 years ago
direct.c	[PATCH] i386: Fix PCI BIOS config space access	19 years ago
early.c	[PATCH] x86: add write_pci_config_byte() to direct PCI access routines	18 years ago
fixup.c	PCI: Fix multiple problems with VIA hardware	18 years ago
i386.c	pci/i386: style cleanups	18 years ago
init.c	[PATCH] i386: Fix PCI BIOS config space access	19 years ago
irq.c	[PATCH] x86: remove last two pci_find offenders in the core code	18 years ago
legacy.c	[PATCH] acpi bridge hotadd: ACPI based root bridge hot-add	20 years ago
mmconfig.c	[PATCH] arch/i386/pci/mmconfig.c tlb flush fix	18 years ago
numa.c	[PATCH] acpi bridge hotadd: ACPI based root bridge hot-add	20 years ago
pcbios.c	[PATCH] paravirt: Be careful about touching BIOS address space	18 years ago
pci.h	PCI: Revert "PCI: i386/x86_84: disable PCI resource decode on device disable"	18 years ago
visws.c	Remove obsolete #include <linux/config.h>	19 years ago