You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

David S. Miller 676d23690f net: Fix use after free by removing length arg from sk_data_ready callbacks. ... Several spots in the kernel perform a sequence like: skb_queue_tail(&sk->s_receive_queue, skb); sk->sk_data_ready(sk, skb->len); But at the moment we place the SKB onto the socket receive queue it can be consumed and freed up. So this skb->len access is potentially to freed up memory. Furthermore, the skb->len can be modified by the consumer so it is possible that the value isn't accurate. And finally, no actual implementation of this callback actually uses the length argument. And since nobody actually cared about it's value, lots of call sites pass arbitrary values in such as '0' and even '1'. So just remove the length argument from the callback, that way there is no confusion whatsoever and all of these use-after-free cases get fixed as a side effect. Based upon a patch by Eric Dumazet and his suggestion to audit this issue tree-wide. Signed-off-by: David S. Miller <davem@davemloft.net>		11 years ago
..
crush	crush: add SET_CHOOSELEAF_VARY_R step	11 years ago
Kconfig	net/ceph: remove depends on CONFIG_EXPERIMENTAL	12 years ago
Makefile	libceph: create source file "net/ceph/snapshot.c"	12 years ago
armor.c	…
auth.c	libceph: wrap auth methods in a mutex	12 years ago
auth_none.c	libceph: Fix NULL pointer dereference in auth client code	12 years ago
auth_none.h	net: 8021q/bluetooth/bridge/can/ceph: Remove extern from function prototypes	11 years ago
auth_x.c	libceph: wrap auth ops in wrapper functions	12 years ago
auth_x.h	net: 8021q/bluetooth/bridge/can/ceph: Remove extern from function prototypes	11 years ago
auth_x_protocol.h	…
buffer.c	libceph: add ceph_kv{malloc,free}() and switch to them	11 years ago
ceph_common.c	libceph: add ceph_kv{malloc,free}() and switch to them	11 years ago
ceph_fs.c	…
ceph_hash.c	…
ceph_strings.c	libceph: update ceph_osd_op_name()	12 years ago
crypto.c	libceph: eliminate sparse warnings	12 years ago
crypto.h	net: 8021q/bluetooth/bridge/can/ceph: Remove extern from function prototypes	11 years ago
debugfs.c	libceph: dump pool {read,write}_tier to debugfs	11 years ago
messenger.c	net: Fix use after free by removing length arg from sk_data_ready callbacks.	11 years ago
mon_client.c	libceph: rename ceph_msg::front_max to front_alloc_len	11 years ago
msgpool.c	…
osd_client.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client	11 years ago
osdmap.c	libceph: output primary affinity values on osdmap updates	11 years ago
pagelist.c	ceph: use list_move_tail instead of list_del/list_add_tail	13 years ago
pagevec.c	libceph: drop return value from page vector copy routines	12 years ago
snapshot.c	libceph: create source file "net/ceph/snapshot.c"	12 years ago