You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

David S. Miller 676d23690f net: Fix use after free by removing length arg from sk_data_ready callbacks. ... Several spots in the kernel perform a sequence like: skb_queue_tail(&sk->s_receive_queue, skb); sk->sk_data_ready(sk, skb->len); But at the moment we place the SKB onto the socket receive queue it can be consumed and freed up. So this skb->len access is potentially to freed up memory. Furthermore, the skb->len can be modified by the consumer so it is possible that the value isn't accurate. And finally, no actual implementation of this callback actually uses the length argument. And since nobody actually cared about it's value, lots of call sites pass arbitrary values in such as '0' and even '1'. So just remove the length argument from the callback, that way there is no confusion whatsoever and all of these use-after-free cases get fixed as a side effect. Based upon a patch by Eric Dumazet and his suggestion to audit this issue tree-wide. Signed-off-by: David S. Miller <davem@davemloft.net>		11 years ago
..
Kconfig	fs/dlm: remove CONFIG_EXPERIMENTAL	12 years ago
Makefile	dlm: move plock code from gfs2	17 years ago
ast.c	dlm: use INFO for recovery messages	11 years ago
ast.h	dlm: use workqueue for callbacks	14 years ago
config.c	dlm: config: using strlcpy instead of strncpy	12 years ago
config.h	dlm: fix deadlock between dlm_send and dlm_controld	13 years ago
debug_fs.c	dlm: use rsbtbl as resource directory	13 years ago
dir.c	dlm: use INFO for recovery messages	11 years ago
dir.h	dlm: use rsbtbl as resource directory	13 years ago
dlm_internal.h	dlm: use INFO for recovery messages	11 years ago
lock.c	dlm: use INFO for recovery messages	11 years ago
lock.h	dlm: use rsbtbl as resource directory	13 years ago
lockspace.c	dlm: use INFO for recovery messages	11 years ago
lockspace.h	dlm: detect available userspace daemon	17 years ago
lowcomms.c	net: Fix use after free by removing length arg from sk_data_ready callbacks.	11 years ago
lowcomms.h	dlm: fix deadlock between dlm_send and dlm_controld	13 years ago
lvb_table.h	…
main.c	dlm: fix deadlock between dlm_send and dlm_controld	13 years ago
member.c	dlm: use INFO for recovery messages	11 years ago
member.h	dlm: add recovery callbacks	13 years ago
memory.c	dlm: NULL dereference on failure in kmem_cache_create()	13 years ago
memory.h	dlm: improve rsb searches	14 years ago
midcomms.c	dlm: fix up memory allocation flags	16 years ago
midcomms.h	…
netlink.c	genetlink: only pass array to genl_register_family_with_ops()	11 years ago
plock.c	dlm: avoid unnecessary posix unlock	12 years ago
rcom.c	dlm: fix unlock balance warnings	13 years ago
rcom.h	dlm: use rsbtbl as resource directory	13 years ago
recover.c	dlm: use INFO for recovery messages	11 years ago
recover.h	dlm: use rsbtbl as resource directory	13 years ago
recoverd.c	dlm: use INFO for recovery messages	11 years ago
recoverd.h	dlm: fix unlock balance warnings	13 years ago
requestqueue.c	dlm: fixes for nodir mode	13 years ago
requestqueue.h	dlm: use proper C for dlm/requestqueue stuff (and fix alignment bug)	17 years ago
user.c	dlm: remove signal blocking	12 years ago
user.h	dlm: record full callback state	14 years ago
util.c	dlm: do not byteswap rcom_config	17 years ago
util.h	…