You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Carsten Otte 0e4a9b5928 ext2/xip: refuse to change xip flag during remount with busy inodes ... For a reason that I was unable to understand in three months of debugging, mount ext2 -o remount stopped working properly when remounting from regular operation to xip, or the other way around. According to a git bisect search, the problem was introduced with the VM_MIXEDMAP/PTE_SPECIAL rework in the vm: commit 70688e4dd1 Author: Nick Piggin <npiggin@suse.de> Date: Mon Apr 28 02:13:02 2008 -0700 xip: support non-struct page backed memory In the failing scenario, the filesystem is mounted read only via root= kernel parameter on s390x. During remount (in rc.sysinit), the inodes of the bash binary and its libraries are busy and cannot be invalidated (the bash which is running rc.sysinit resides on subject filesystem). Afterwards, another bash process (running ifup-eth) recurses into a subshell, runs dup_mm (via fork). Some of the mappings in this bash process were created from inodes that could not be invalidated during remount. Both parent and child process crash some time later due to inconsistencies in their address spaces. The issue seems to be timing sensitive, various attempts to recreate it have failed. This patch refuses to change the xip flag during remount in case some inodes cannot be invalidated. This patch keeps users from running into that issue. [akpm@linux-foundation.org: cleanup] Signed-off-by: Carsten Otte <cotte@de.ibm.com> Cc: Nick Piggin <npiggin@suse.de> Cc: Jared Hulbert <jaredeh@gmail.com> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		16 years ago
..
9p	fs/Kconfig: move 9p out	16 years ago
adfs	fs/Kconfig: move adfs out	16 years ago
affs	fs/Kconfig: move affs out	16 years ago
afs	fs/Kconfig: move afs out	16 years ago
autofs	fs/Kconfig: move autofs, autofs4 out	16 years ago
autofs4	fs/Kconfig: move autofs, autofs4 out	16 years ago
befs	fs/Kconfig: move befs out	16 years ago
bfs	fs/Kconfig: move bfs out	16 years ago
btrfs	Btrfs: don't use spin_is_contended	16 years ago
cifs	cifs: make sure we allocate enough storage for socket address	16 years ago
coda	fs/Kconfig: move coda out	16 years ago
configfs	Revert "configfs: Silence lockdep on mkdir(), rmdir() and configfs_depend_item()"	16 years ago
cramfs	fs/Kconfig: move cramfs out	16 years ago
debugfs	debugfs: add helpers for exporting a size_t simple value	16 years ago
devpts	zero i_uid/i_gid on inode allocation	16 years ago
dlm	dlm: initialize file_lock struct in GETLK before copying conflicting lock	16 years ago
ecryptfs	eCryptfs: Regression in unencrypted filename symlinks	16 years ago
efs	fs/Kconfig: move efs out	16 years ago
exportfs	…
ext2	ext2/xip: refuse to change xip flag during remount with busy inodes	16 years ago
ext3	ext3: revert "ext3: wait on all pending commits in ext3_sync_fs"	16 years ago
ext4	ext4: Remove bogus BUG() check in ext4_bmap()	16 years ago
fat	fs/Kconfig: move fat out	16 years ago
freevxfs	fs/Kconfig: move vxfs out	16 years ago
fuse	Merge branch 'Kconfig' of git://git.kernel.org/pub/scm/linux/kernel/git/adobriyan/misc	16 years ago
gfs2	filesystem freeze: add error handling of write_super_lockfs/unlockfs	16 years ago
hfs	fs/Kconfig: move hfs, hfsplus out	16 years ago
hfsplus	fs/Kconfig: move hfs, hfsplus out	16 years ago
hostfs	fs: symlink write_begin allocation context fix	16 years ago
hpfs	fs/Kconfig: move hpfs out	16 years ago
hppfs	…
hugetlbfs	Do not account for the address space used by hugetlbfs using VM_ACCOUNT	16 years ago
isofs	fs/Kconfig: move iso9660, udf out	16 years ago
jbd	jbd: fix return value of journal_start_commit()	16 years ago
jbd2	ext4: fix wrong use of do_div	16 years ago
jffs2	[JFFS2] remove junk prototypes	16 years ago
jfs	fs/Kconfig: move jfs out	16 years ago
lockd	lockd: fix regression in lockd's handling of blocked locks	16 years ago
minix	fs/Kconfig: move minix out	16 years ago
ncpfs	fs/Kconfig: move the rest of ncpfs out	16 years ago
nfs	fs/Kconfig: move nfs out	16 years ago
nfs_common	…
nfsd	nfsd: only set file_lock.fl_lmops in nfsd4_lockt if a stateowner is found	16 years ago
nls	…
notify	inotify: clean up inotify_read and fix locking problems	16 years ago
ntfs	fs/Kconfig: move ntfs out	16 years ago
ocfs2	ocfs2: add quota call to ocfs2_remove_btree_range()	16 years ago
omfs	fs/Kconfig: move omfs out	16 years ago
openpromfs	zero i_uid/i_gid on inode allocation	16 years ago
partitions	block: fix bug in ptbl lookup cache	16 years ago
proc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-2.6-nommu	16 years ago
qnx4	fs/Kconfig: move qnx4 out	16 years ago
ramfs	NOMMU: Fix cleanup handling in ramfs_nommu_get_umapped_area()	16 years ago
reiserfs	fs/Kconfig: move reiserfs out	16 years ago
romfs	fs/Kconfig: move romfs out	16 years ago
smbfs	fs/Kconfig: move smbfs out	16 years ago
squashfs	fs/Kconfig: move squashfs out	16 years ago
sysfs	Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core-2.6	16 years ago
sysv	fs/Kconfig: move sysv out	16 years ago
ubifs	UBIFS: remove fast unmounting	16 years ago
udf	fs/Kconfig: move iso9660, udf out	16 years ago
ufs	fs/Kconfig: move ufs out	16 years ago
xfs	[XFS] Warn on transaction in flight on read-only remount	16 years ago
Kconfig	fs/Kconfig: move 9p out	16 years ago
Kconfig.binfmt	CORE_DUMP_DEFAULT_ELF_HEADERS depends on ELF_CORE	16 years ago
Makefile	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pkl/squashfs-linus	16 years ago
aio.c	[CVE-2009-0029] System call wrappers part 16	16 years ago
anon_inodes.c	anon_inodes: use fops->owner for module refcount	16 years ago
attr.c	…
bad_inode.c	kill ->dir_notify()	16 years ago
binfmt_aout.c	sanitize ifdefs in binfmt_aout	16 years ago
binfmt_elf.c	elf core dump: fix get_user use	16 years ago
binfmt_elf_fdpic.c	FDPIC: Don't attempt to expand the userspace stack to fill the space allocated	16 years ago
binfmt_em86.c	…
binfmt_flat.c	FLAT: Don't attempt to expand the userspace stack to fill the space allocated	16 years ago
binfmt_misc.c	fs/binfmt_misc.c: add terminating newline to /proc/sys/fs/binfmt_misc/status	16 years ago
binfmt_script.c	…
binfmt_som.c	…
bio-integrity.c	block: Remove obsolete BUG_ON	16 years ago
bio.c	[SCSI] block: make blk_rq_map_user take a NULL user-space buffer for WRITE	16 years ago
block_dev.c	filesystem freeze: implement generic freeze feature	16 years ago
buffer.c	vfs: Don't call attach_nobh_buffers() with an empty list	16 years ago
char_dev.c	fs: fix name overwrite in __register_chrdev_region()	16 years ago
compat.c	CRED: Fix SUID exec regression	16 years ago
compat_binfmt_elf.c	…
compat_ioctl.c	braino in sg_ioctl_trans()	16 years ago
dcache.c	[CVE-2009-0029] System call wrappers part 20	16 years ago
dcookies.c	[CVE-2009-0029] System call wrapper special cases	16 years ago
direct-io.c	fs: truncate blocks outside i_size after O_DIRECT write error	16 years ago
dquot.c	quota: Improve locking	16 years ago
drop_caches.c	…
eventfd.c	[CVE-2009-0029] System call wrappers part 32	16 years ago
eventpoll.c	epoll: drop max_user_instances and rely only on max_user_watches	16 years ago
exec.c	CRED: Fix SUID exec regression	16 years ago
fcntl.c	[CVE-2009-0029] System call wrappers part 15	16 years ago
fifo.c	…
file.c	…
file_table.c	filp_cachep can be static in fs/file_table.c	16 years ago
filesystems.c	[CVE-2009-0029] System call wrappers part 27	16 years ago
fs-writeback.c	fs: sys_sync fix	16 years ago
generic_acl.c	…
inode.c	partial revert of asynchronous inode delete	16 years ago
internal.h	CRED: Fix SUID exec regression	16 years ago
ioctl.c	[CVE-2009-0029] System call wrappers part 15	16 years ago
ioprio.c	[CVE-2009-0029] System call wrappers part 28	16 years ago
libfs.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6	16 years ago
locks.c	[CVE-2009-0029] System call wrappers part 16	16 years ago
mbcache.c	…
mpage.c	do_mpage_readpage(): remove useless clear_buffer_mapped() call	16 years ago
namei.c	[CVE-2009-0029] System call wrappers part 29	16 years ago
namespace.c	[CVE-2009-0029] System call wrappers part 14	16 years ago
nfsctl.c	[CVE-2009-0029] System call wrappers part 27	16 years ago
no-block.c	…
open.c	[CVE-2009-0029] System call wrappers part 30	16 years ago
pipe.c	[CVE-2009-0029] System call wrappers part 33	16 years ago
pnode.c	…
pnode.h	…
posix_acl.c	…
quota.c	[CVE-2009-0029] System call wrappers part 20	16 years ago
quota_tree.c	quota: Split off quota tree handling into a separate file	16 years ago
quota_tree.h	quota: Split off quota tree handling into a separate file	16 years ago
quota_v1.c	quota: Move quotaio_v[12].h from include/linux/ to fs/	16 years ago
quota_v2.c	quota: Convert union in mem_dqinfo to a pointer	16 years ago
quotaio_v1.h	quota: Move quotaio_v[12].h from include/linux/ to fs/	16 years ago
quotaio_v2.h	quota: Split off quota tree handling into a separate file	16 years ago
read_write.c	[CVE-2009-0029] System call wrappers part 20	16 years ago
read_write.h	…
readdir.c	[CVE-2009-0029] System call wrappers part 32	16 years ago
select.c	[CVE-2009-0029] System call wrappers part 32	16 years ago
seq_file.c	seq_file: fix big-enough lseek() + read()	16 years ago
signalfd.c	[CVE-2009-0029] System call wrappers part 31	16 years ago
splice.c	[CVE-2009-0029] System call wrappers part 31	16 years ago
stack.c	…
stat.c	[CVE-2009-0029] System call wrappers part 30	16 years ago
super.c	async: Rename _special -> _domain for clarity.	16 years ago
sync.c	[CVE-2009-0029] System call wrappers part 09	16 years ago
timerfd.c	[CVE-2009-0029] System call wrappers part 32	16 years ago
utimes.c	[CVE-2009-0029] System call wrappers part 30	16 years ago
xattr.c	[CVE-2009-0029] System call wrappers part 13	16 years ago
xattr_acl.c	…