You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Linus Torvalds 80e1e82398 Fix race in tty_fasync() properly ... This reverts commit 7036251180 ("tty: fix race in tty_fasync") and commit b04da8bfdf ("fnctl: f_modown should call write_lock_irqsave/ restore") that tried to fix up some of the fallout but was incomplete. It turns out that we really cannot hold 'tty->ctrl_lock' over calling __f_setown, because not only did that cause problems with interrupt disables (which the second commit fixed), it also causes a potential ABBA deadlock due to lock ordering. Thanks to Tetsuo Handa for following up on the issue, and running lockdep to show the problem. It goes roughly like this: - f_getown gets filp->f_owner.lock for reading without interrupts disabled, so an interrupt that happens while that lock is held can cause a lockdep chain from f_owner.lock -> sighand->siglock. - at the same time, the tty->ctrl_lock -> f_owner.lock chain that commit 7036251180 introduced, together with the pre-existing sighand->siglock -> tty->ctrl_lock chain means that we have a lock dependency the other way too. So instead of extending tty->ctrl_lock over the whole __f_setown() call, we now just take a reference to the 'pid' structure while holding the lock, and then release it after having done the __f_setown. That still guarantees that 'struct pid' won't go away from under us, which is all we really ever needed. Reported-and-tested-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Acked-by: Américo Wang <xiyou.wangcong@gmail.com> Cc: stable@kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		15 years ago
..
accessibility	…
acpi	Merge branch 'bugzilla-14954' into release	15 years ago
amba	…
ata	[libata] Call flush_dcache_page after PIO data transfers in libata-sff.c	15 years ago
atm	…
auxdisplay	…
base	Revert "sysdev: fix prototype for memory_sysdev_class show/store functions"	15 years ago
block	pktcdvd: removing device does not remove its sysfs dir	15 years ago
bluetooth	Bluetooth: Add DFU driver for Atheros Bluetooth chipset AR3011	15 years ago
cdrom	…
char	Fix race in tty_fasync() properly	15 years ago
clocksource	…
connector	connector: Delete buggy notification code.	15 years ago
cpufreq	…
cpuidle	…
crypto	crypto: padlock-sha - Add import/export support	15 years ago
dca	…
dio	…
dma	…
edac	…
eisa	…
firewire	firewire: ohci: fix crashes with TSB43AB23 on 64bit systems	15 years ago
firmware	…
gpio	…
gpu	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/anholt/drm-intel	15 years ago
hid	…
hwmon	hwmon: (w83781d) Request I/O ports individually for probing	15 years ago
i2c	i2c: imx: call ioremap only after request_mem_region	15 years ago
ide	…
idle	…
ieee1394	…
ieee802154	…
infiniband	Fix failure exit in ipathfs	15 years ago
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	15 years ago
isdn	…
leds	…
lguest	…
macintosh	…
mca	…
md	…
media	saa7146: stop DMA before de-allocating DMA scatter/gather page buffers	15 years ago
memstick	…
message	[SCSI] mptsas: Fix issue with chain pools allocation on katmai	15 years ago
mfd	mfd: Fix asic3 build	15 years ago
misc	…
mmc	mfd: tmio_mmc hardware abstraction for CNF area	15 years ago
mtd	Merge branch 'for-linus' of git://git.infradead.org/ubi-2.6	15 years ago
net	be2net: use eq-id to calculate cev-isr reg offset	15 years ago
nubus	…
of	…
oprofile	…
parisc	…
parport	…
pci	CS5536: apply pci quirk for BIOS SMBUS bug	15 years ago
pcmcia	…
platform	Merge branch 'misc' into release	15 years ago
pnp	…
power	…
pps	…
ps3	…
rapidio	…
regulator	regulator: Specify REGULATOR_CHANGE_STATUS for WM835x LED constraints	15 years ago
rtc	rtc-fm3130: add missing braces	15 years ago
s390	Merge git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6	15 years ago
sbus	…
scsi	[SCSI] aic79xx: check for non-NULL scb in ahd_handle_nonpkt_busfree	15 years ago
serial	uartlite: fix crash when using as console	15 years ago
sfi	…
sh	…
sn	…
spi	spi: spi_sh_msiof: Fixed data sampling on the correct edge	15 years ago
ssb	…
staging	Merge branch 'drm-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6	15 years ago
tc	…
telephony	…
thermal	…
uio	…
usb	usb: r8a66597-hdc disable interrupts fix	15 years ago
uwb	…
video	imxfb: correct location of callbacks in suspend and resume	15 years ago
virtio	…
vlynq	…
w1	…
watchdog	[WATCHDOG] sbc_fitpc2_wdt: fix I/O space access technique.	15 years ago
xen	…
zorro	…
Kconfig	…
Makefile	…