You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Hannes Frederic Sowa f3d3342602 net: rework recvmsg handler msg_name and msg_namelen logic ... This patch now always passes msg->msg_namelen as 0. recvmsg handlers must set msg_namelen to the proper size <= sizeof(struct sockaddr_storage) to return msg_name to the user. This prevents numerous uninitialized memory leaks we had in the recvmsg handlers and makes it harder for new code to accidentally leak uninitialized memory. Optimize for the case recvfrom is called with NULL as address. We don't need to copy the address at all, so set it to NULL before invoking the recvmsg handler. We can do so, because all the recvmsg handlers must cope with the case a plain read() is called on them. read() also sets msg_name to NULL. Also document these changes in include/linux/net.h as suggested by David Miller. Changes since RFC: Set msg->msg_name = NULL if user specified a NULL in msg_name but had a non-null msg_namelen in verify_iovec/verify_compat_iovec. This doesn't affect sendto as it would bail out earlier while trying to copy-in the address. It also more naturally reflects the logic by the callers of verify_iovec. With this change in place I could remove " if (!uaddr || msg_sys->msg_namelen == 0) msg->msg_name = NULL ". This change does not alter the user visible error logic as we ignore msg_namelen as long as msg_name is NULL. Also remove two unnecessary curly brackets in ___sys_recvmsg and change comments to netdev style. Cc: David Miller <davem@davemloft.net> Suggested-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org> Signed-off-by: David S. Miller <davem@davemloft.net>		11 years ago
..
Kconfig	net: x25: Fix dead URLs in Kconfig	11 years ago
Makefile	…
af_x25.c	net: rework recvmsg handler msg_name and msg_namelen logic	11 years ago
sysctl_net_x25.c	…
x25_dev.c	net: add a limit parameter to sk_add_backlog()	13 years ago
x25_facilities.c	x25: add a sanity check parsing X.25 facilities	12 years ago
x25_forward.c	…
x25_in.c	…
x25_link.c	…
x25_out.c	…
x25_proc.c	x25: use proc_remove_subtree()	12 years ago
x25_route.c	net: Fix (nearly-)kernel-doc comments for various functions	13 years ago
x25_subr.c	…
x25_timer.c	…