You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Hannes Frederic Sowa f3d3342602 net: rework recvmsg handler msg_name and msg_namelen logic ... This patch now always passes msg->msg_namelen as 0. recvmsg handlers must set msg_namelen to the proper size <= sizeof(struct sockaddr_storage) to return msg_name to the user. This prevents numerous uninitialized memory leaks we had in the recvmsg handlers and makes it harder for new code to accidentally leak uninitialized memory. Optimize for the case recvfrom is called with NULL as address. We don't need to copy the address at all, so set it to NULL before invoking the recvmsg handler. We can do so, because all the recvmsg handlers must cope with the case a plain read() is called on them. read() also sets msg_name to NULL. Also document these changes in include/linux/net.h as suggested by David Miller. Changes since RFC: Set msg->msg_name = NULL if user specified a NULL in msg_name but had a non-null msg_namelen in verify_iovec/verify_compat_iovec. This doesn't affect sendto as it would bail out earlier while trying to copy-in the address. It also more naturally reflects the logic by the callers of verify_iovec. With this change in place I could remove " if (!uaddr || msg_sys->msg_namelen == 0) msg->msg_name = NULL ". This change does not alter the user visible error logic as we ignore msg_namelen as long as msg_name is NULL. Also remove two unnecessary curly brackets in ___sys_recvmsg and change comments to netdev style. Cc: David Miller <davem@davemloft.net> Suggested-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org> Signed-off-by: David S. Miller <davem@davemloft.net>		11 years ago
..
ircomm	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	12 years ago
irlan	net/irda: fixed style issues in irlan_eth	12 years ago
irnet	net: misc: Remove extern from function prototypes	11 years ago
Kconfig	…
Makefile	…
af_irda.c	net: rework recvmsg handler msg_name and msg_namelen logic	11 years ago
discovery.c	net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules	13 years ago
irda_device.c	net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules	13 years ago
iriap.c	irda: small read past the end of array in debug code	12 years ago
iriap_event.c	…
irias_object.c	…
irlap.c	Fix common misspellings	14 years ago
irlap_event.c	irda: irlap_event: Fix set-but-unused variables.	14 years ago
irlap_frame.c	net: irda: using kzalloc() instead of kmalloc() to avoid strncpy() issue.	12 years ago
irlmp.c	irda: irlmp_reasons[] can be static	12 years ago
irlmp_event.c	Fix common misspellings	14 years ago
irlmp_frame.c	…
irmod.c	…
irnetlink.c	genetlink: only pass array to genl_register_family_with_ops()	11 years ago
irproc.c	irda: irproc: Fix set-but-unused variables.	14 years ago
irqueue.c	net: Remove casts to same type	13 years ago
irsysctl.c	net: Convert uses of typedef ctl_table to struct ctl_table	12 years ago
irttp.c	net/irda: fixed style issues in irttp	12 years ago
parameters.c	…
qos.c	net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules	13 years ago
timer.c	treewide: Replace incomming with incoming in all comments and strings	12 years ago
wrapper.c	…