You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Ville Syrjälä 668e3b014a drm/i915: Fix runtime PM for LPE audio ... Not calling pm_runtime_enable() means that runtime PM can't be enabled at all via sysfs. So we definitely need to call it from somewhere. Calling it from the driver seems like a bad idea because it would have to be paired with a pm_runtime_disable() at driver unload time, otherwise the core gets upset. Also if there's no LPE audio driver loaded then we couldn't runtime suspend i915 either. So it looks like a better plan is to call it from i915 when we register the platform device. That seems to match how pci generally does things. I cargo culted the pm_runtime_forbid() and pm_runtime_set_active() calls from pci as well. The exposed runtime PM API is massive an thorougly misleading, so I don't actually know if this is how you're supposed to use the API or not. But it seems to work. I can now runtime suspend i915 again with or without the LPE audio driver loaded, and reloading the LPE audio driver also seems to work. Note that powertop won't auto-tune runtime PM for platform devices, which is a little annoying. So I'm not sure that leaving runtime PM in "on" mode by default is the best choice here. But I've left it like that for now at least. Also remove the comment about there not being much benefit from LPE audio runtime PM. Not allowing runtime PM blocks i915 runtime PM, which will also block s0ix, and that could have a measurable impact on power consumption. Cc: stable@vger.kernel.org Cc: Takashi Iwai <tiwai@suse.de> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Fixes: 0b6b524f39 ("ALSA: x86: Don't enable runtime PM as default") Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/20170427160231.13337-2-ville.syrjala@linux.intel.com Reviewed-by: Takashi Iwai <tiwai@suse.de> (cherry picked from commit 183c00350c) Signed-off-by: Jani Nikula <jani.nikula@intel.com>		8 years ago
..
aoa	…
arm	…
atmel	…
core	Merge branch 'for-linus' into for-next	8 years ago
drivers	Annotation of module parameters that specify device settings	8 years ago
firewire	ALSA: fireface: obsolete usage of ktime_set() for zero assignment	8 years ago
hda	ALSA: hda: Fix cpu lockup when stopping the cmd dmas	8 years ago
i2c	…
isa	Annotation of module parameters that specify device settings	8 years ago
mips	ALSA: mips: avoid potential uninitialized variable use	8 years ago
oss	Annotate hardware config module parameters in sound/oss/	8 years ago
parisc	…
pci	sound fixes for 4.12-rc1	8 years ago
pcmcia	lib/vsprintf.c: remove %Z support	8 years ago
ppc	scripts/spelling.txt: add "followings" pattern and fix typo instances	8 years ago
sh	…
soc	scripts/spelling.txt: add regsiter -> register spelling mistake	8 years ago
sparc	…
spi	…
synth	ALSA: emux: stop if copy_from_user() fails	8 years ago
usb	ALSA: usb-audio: replace /proc/bus/usb by /dev/bus/usb	8 years ago
x86	drm/i915: Fix runtime PM for LPE audio	8 years ago
Kconfig	sound: Disable the build of OSS drivers	8 years ago
Makefile	ALSA: add Intel HDMI LPE audio driver for BYT/CHT-T	8 years ago
ac97_bus.c	…
last.c	…
sound_core.c	…