You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Jianpeng Ma 0676806707 block: Don't use static to define "void *p" in show_partition_start() ... I met a odd prblem:read /proc/partitions may return zero. I wrote a file test.c: int main() { char buff[4096]; int ret; int fd; printf("pid=%d\n",getpid()); while (1) { fd = open("/proc/partitions", O_RDONLY); if (fd < 0) { printf("open error %s\n", strerror(errno)); return 0; } ret = read(fd, buff, 4096); if (ret <= 0) printf("ret=%d, %s, %ld\n", ret, strerror(errno), lseek(fd,0,SEEK_CUR)); close(fd); } exit(0); } You can reproduce by: 1:while true;do cat /proc/partitions > /dev/null ;done 2:./test I reviewed the code and found: >> static void *show_partition_start(struct seq_file *seqf, loff_t *pos) >> { >> static void *p; >> >> p = disk_seqf_start(seqf, pos); >> if (!IS_ERR_OR_NULL(p) && !*pos) >> seq_puts(seqf, "major minor #blocks name\n\n"); >> return p; >> } test cat /proc/partitions p = disk_seqf_start()(Not NULL) p = disk_seqf_start()(NULL because pos) if (!IS_ERR_OR_NULL(p) && !*pos) Signed-off-by: Jianpeng Ma <majianpeng@gmail.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>		13 years ago
..
partitions	s390/dasd: re-prioritize partition detection message	13 years ago
Kconfig	…
Kconfig.iosched	blkcg: make CONFIG_BLK_CGROUP bool	13 years ago
Makefile	…
blk-cgroup.c	blkcg: implement per-blkg request allocation	13 years ago
blk-cgroup.h	blkcg: implement per-blkg request allocation	13 years ago
blk-core.c	blk: pass from_schedule to non-request unplug functions.	13 years ago
blk-exec.c	[SCSI] block: Fix blk_execute_rq_nowait() dead queue handling	13 years ago
blk-flush.c	…
blk-integrity.c	…
blk-ioc.c	block: uninitialized ioc->nr_tasks triggers WARN_ON	13 years ago
blk-iopoll.c	…
blk-lib.c	block: split discard into aligned requests	13 years ago
blk-map.c	…
blk-merge.c	block: Add blk_bio_map_sg() helper	13 years ago
blk-settings.c	block: do not artificially constrain max_sectors for stacking drivers	13 years ago
blk-softirq.c	sched, block: Unify cache detection	13 years ago
blk-sysfs.c	blkcg: implement per-blkg request allocation	13 years ago
blk-tag.c	…
blk-throttle.c	block: allocate io_context upfront	13 years ago
blk-timeout.c	block: Drop dead function blk_abort_queue()	13 years ago
blk.h	block: remove dead func declaration	13 years ago
bsg-lib.c	block: drop custom queue draining used by scsi_transport_{iscsi|fc}	13 years ago
bsg.c	bsg: fix sysfs link remove warning	13 years ago
cfq-iosched.c	block: blkcg_policy_cfq shouldn't be used if !CONFIG_CFQ_GROUP_IOSCHED	13 years ago
compat_ioctl.c	…
deadline-iosched.c	elevator: make elevator_init_fn() return 0/-errno	13 years ago
elevator.c	blkcg: implement per-queue policy activation	13 years ago
genhd.c	block: Don't use static to define "void *p" in show_partition_start()	13 years ago
ioctl.c	block: add partition resize function to blkpg ioctl	13 years ago
noop-iosched.c	elevator: make elevator_init_fn() return 0/-errno	13 years ago
partition-generic.c	block: add partition resize function to blkpg ioctl	13 years ago
scsi_ioctl.c	scsi: Silence unnecessary warnings about ioctl to partition	13 years ago