You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Jeff Layton cd123012d9 RPC: add wrapper for svc_reserve to account for checksum ... When the kernel calls svc_reserve to downsize the expected size of an RPC reply, it fails to account for the possibility of a checksum at the end of the packet. If a client mounts a NFSv2/3 with sec=krb5i/p, and does I/O then you'll generally see messages similar to this in the server's ring buffer: RPC request reserved 164 but used 208 While I was never able to verify it, I suspect that this problem is also the root cause of some oopses I've seen under these conditions: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227726 This is probably also a problem for other sec= types and for NFSv4. The large reserved size for NFSv4 compound packets seems to generally paper over the problem, however. This patch adds a wrapper for svc_reserve that accounts for the possibility of a checksum. It also fixes up the appropriate callers of svc_reserve to call the wrapper. For now, it just uses a hardcoded value that I determined via testing. That value may need to be revised upward as things change, or we may want to eventually add a new auth_op that attempts to calculate this somehow. Unfortunately, there doesn't seem to be a good way to reliably determine the expected checksum length prior to actually calculating it, particularly with schemes like spkm3. Signed-off-by: Jeff Layton <jlayton@redhat.com> Acked-by: Neil Brown <neilb@suse.de> Cc: Trond Myklebust <trond.myklebust@fys.uio.no> Acked-by: J. Bruce Fields <bfields@citi.umich.edu> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		18 years ago
..
Kbuild	…
auth.h	…
auth_gss.h	rpc: gss: eliminate print_hexl()'s	18 years ago
cache.h	…
clnt.h	SUNRPC: remove old portmapper	18 years ago
debug.h	SUNRPC: remove old portmapper	18 years ago
gss_api.h	…
gss_asn1.h	…
gss_err.h	…
gss_krb5.h	rpcgss: krb5: ignore seed	18 years ago
gss_spkm3.h	rpc: spkm3 update	18 years ago
metrics.h	…
msg_prot.h	SUNRPC: remove old portmapper	18 years ago
rpc_pipe_fs.h	WorkStruct: Separate delayable and non-delayable events.	18 years ago
sched.h	SUNRPC: Eliminate side effects from rpc_malloc	18 years ago
stats.h	…
svc.h	RPC: add wrapper for svc_reserve to account for checksum	18 years ago
svcauth.h	…
svcauth_gss.h	…
svcsock.h	knfsd: rename sk_defer_lock to sk_lock	18 years ago
timer.h	…
types.h	…
xdr.h	SUNRPC: Rename skb_reader_t and friends	18 years ago
xprt.h	SUNRPC: introduce rpcbind: replacement for in-kernel portmapper	18 years ago