You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

David S. Miller 676d23690f net: Fix use after free by removing length arg from sk_data_ready callbacks. ... Several spots in the kernel perform a sequence like: skb_queue_tail(&sk->s_receive_queue, skb); sk->sk_data_ready(sk, skb->len); But at the moment we place the SKB onto the socket receive queue it can be consumed and freed up. So this skb->len access is potentially to freed up memory. Furthermore, the skb->len can be modified by the consumer so it is possible that the value isn't accurate. And finally, no actual implementation of this callback actually uses the length argument. And since nobody actually cared about it's value, lots of call sites pass arbitrary values in such as '0' and even '1'. So just remove the length argument from the callback, that way there is no confusion whatsoever and all of these use-after-free cases get fixed as a side effect. Based upon a patch by Eric Dumazet and his suggestion to audit this issue tree-wide. Signed-off-by: David S. Miller <davem@davemloft.net>		11 years ago
..
Kconfig	net/rxrpc: remove depends on CONFIG_EXPERIMENTAL	12 years ago
Makefile	af_rxrpc: Add sysctls for configuring RxRPC parameters	11 years ago
af_rxrpc.c	af_rxrpc: Add sysctls for configuring RxRPC parameters	11 years ago
ar-accept.c	…
ar-ack.c	af_rxrpc: Expose more RxRPC parameters via sysctls	11 years ago
ar-call.c	af_rxrpc: Keep rxrpc_call pointers in a hashtable	11 years ago
ar-connection.c	af_rxrpc: Add sysctls for configuring RxRPC parameters	11 years ago
ar-connevent.c	…
ar-error.c	af_rxrpc: Fix UDP MTU calculation from ICMP_FRAG_NEEDED	11 years ago
ar-input.c	net: Fix use after free by removing length arg from sk_data_ready callbacks.	11 years ago
ar-internal.h	net: Fix use after free by removing length arg from sk_data_ready callbacks.	11 years ago
ar-key.c	…
ar-local.c	…
ar-output.c	af_rxrpc: Request an ACK for every alternate DATA packet	11 years ago
ar-peer.c	…
ar-proc.c	…
ar-recvmsg.c	af_rxrpc: Remove incorrect checksum calculation from rxrpc_recvmsg()	11 years ago
ar-security.c	…
ar-skbuff.c	af_rxrpc: Improve ACK production	11 years ago
ar-transport.c	af_rxrpc: Add sysctls for configuring RxRPC parameters	11 years ago
rxkad.c	…
sysctl.c	af_rxrpc: Expose more RxRPC parameters via sysctls	11 years ago