You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Alexei Starovoitov 725f9dcd58 bpf: fix two bugs in verification logic when accessing 'ctx' pointer ... 1. first bug is a silly mistake. It broke tracing examples and prevented simple bpf programs from loading. In the following code: if (insn->imm == 0 && BPF_SIZE(insn->code) == BPF_W) { } else if (...) { // this part should have been executed when // insn->code == BPF_W and insn->imm != 0 } Obviously it's not doing that. So simple instructions like: r2 = *(u64 *)(r1 + 8) will be rejected. Note the comments in the code around these branches were and still valid and indicate the true intent. Replace it with: if (BPF_SIZE(insn->code) != BPF_W) continue; if (insn->imm == 0) { } else if (...) { // now this code will be executed when // insn->code == BPF_W and insn->imm != 0 } 2. second bug is more subtle. If malicious code is using the same dest register as source register, the checks designed to prevent the same instruction to be used with different pointer types will fail to trigger, since we were assigning src_reg_type when it was already overwritten by check_mem_access(). The fix is trivial. Just move line: src_reg_type = regs[insn->src_reg].type; before check_mem_access(). Add new 'access skb fields bad4' test to check this case. Fixes: 9bac3d6d54 ("bpf: allow extended BPF programs access skb fields") Signed-off-by: Alexei Starovoitov <ast@plumgrid.com> Signed-off-by: David S. Miller <davem@davemloft.net>		10 years ago
..
bpf	bpf: fix two bugs in verification logic when accessing 'ctx' pointer	10 years ago
hidraw	HID: samples/hidraw: make it possible to select device	10 years ago
hw_breakpoint	…
kdb	…
kfifo	kfifo API type safety	11 years ago
kobject	samples/kobject: be explicit in the module license	10 years ago
kprobes	kprobes: update jprobe_example.c for do_fork() change	11 years ago
livepatch	livepatch: rename config to CONFIG_LIVEPATCH	10 years ago
pktgen	samples/pktgen: Show the results rather than just commenting where they are	10 years ago
rpmsg	misc: remove __dev* attributes.	12 years ago
seccomp	samples/seccomp: improve label helper	10 years ago
trace_events	tracing/samples: Update the trace-event-sample.h with TRACE_DEFINE_ENUM()	10 years ago
uhid	HID: uhid: improve uhid example client	12 years ago
Kconfig	livepatch: rename config to CONFIG_LIVEPATCH	10 years ago
Makefile	livepatch: samples: add sample live patching module	10 years ago