You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Eric Dumazet e014debecd linkwatch: linkwatch_forget_dev() to speedup device dismantle ... Herbert Xu a écrit : > On Tue, Nov 17, 2009 at 04:26:04AM -0800, David Miller wrote: >> Really, the link watch stuff is just due for a redesign. I don't >> think a simple hack is going to cut it this time, sorry Eric :-) > > I have no objections against any redesigns, but since the only > caller of linkwatch_forget_dev runs in process context with the > RTNL, it could also legally emit those events. Thanks guys, here an updated version then, before linkwatch surgery ? In this version, I force the event to be sent synchronously. [PATCH net-next-2.6] linkwatch: linkwatch_forget_dev() to speedup device dismantle time ip link del eth3.103 ; time ip link del eth3.104 ; time ip link del eth3.105 real 0m0.266s user 0m0.000s sys 0m0.001s real 0m0.770s user 0m0.000s sys 0m0.000s real 0m1.022s user 0m0.000s sys 0m0.000s One problem of current schem in vlan dismantle phase is the holding of device done by following chain : vlan_dev_stop() -> netif_carrier_off(dev) -> linkwatch_fire_event(dev) -> dev_hold() ... And __linkwatch_run_queue() runs up to one second later... A generic fix to this problem is to add a linkwatch_forget_dev() method to unlink the device from the list of watched devices. dev->link_watch_next becomes dev->link_watch_list (and use a bit more memory), to be able to unlink device in O(1). After patch : time ip link del eth3.103 ; time ip link del eth3.104 ; time ip link del eth3.105 real 0m0.024s user 0m0.000s sys 0m0.000s real 0m0.032s user 0m0.000s sys 0m0.001s real 0m0.033s user 0m0.000s sys 0m0.000s Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		15 years ago
..
9p	virtio: add virtio IDs file	16 years ago
802	net: remove COMPAT_NET_DEV_OPS	16 years ago
8021q	vlan: Precise RX stats accounting	15 years ago
appletalk	net/appletalk: using compat_ptr needs inclusion of linux/compat.h	15 years ago
atm	net/atm: move all compat_ioctl handling to atm/ioctl.c	15 years ago
ax25	net: pass kern to net_proto_family create function	15 years ago
bluetooth	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	15 years ago
bridge	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	15 years ago
can	CAN: use dev_get_by_index_rcu	15 years ago
core	linkwatch: linkwatch_forget_dev() to speedup device dismantle	15 years ago
dcb	net: fix double skb free in dcbnl	16 years ago
dccp	net: drop capability from protocol definitions	15 years ago
decnet	decnet: convert dndev_lock to spinlock	15 years ago
dsa	netdev: convert pseudo-devices to netdev_tx_t	16 years ago
econet	net: pass kern to net_proto_family create function	15 years ago
ethernet	remove deprecated and not used: print_mac()	15 years ago
ieee802154	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/lowpan/lowpan	15 years ago
ipv4	ipv4: factorize cache clearing for batched unregister operations	15 years ago
ipv6	ipv6: speedup inet6_dump_addr()	15 years ago
ipx	net/ipx: push down BKL into a ipx_dgram_ops	15 years ago
irda	net/irda: push BKL into proto_ops	15 years ago
iucv	iucv: add work_queue cleanup for suspend	15 years ago
key	net: pass kern to net_proto_family create function	15 years ago
lapb	net: remove NET_RX_BAD and NET_RX_CN* defines	16 years ago
llc	net: pass kern to net_proto_family create function	15 years ago
mac80211	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next-2.6	15 years ago
netfilter	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	15 years ago
netlabel	netlabel: remove dev_put() calls	15 years ago
netlink	netlink: remove subscriptions check on notifier	15 years ago
netrom	net: pass kern to net_proto_family create function	15 years ago
packet	net: netlink_getname, packet_getname -- use DECLARE_SOCKADDR guard	15 years ago
phonet	Phonet: missing rcu_dereference()	15 years ago
rds	net: pass kern to net_proto_family create function	15 years ago
rfkill	headers: remove sched.h from poll.h	16 years ago
rose	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	15 years ago
rxrpc	net: pass kern to net_proto_family create function	15 years ago
sched	act_mirred: optimization.	15 years ago
sctp	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	15 years ago
sunrpc	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	15 years ago
tipc	net: pass kern to net_proto_family create function	15 years ago
unix	net: netlink_getname, packet_getname -- use DECLARE_SOCKADDR guard	15 years ago
wanrouter	headers: smp_lock.h redux	16 years ago
wimax	wimax: allow WIMAX_RF_QUERY calls when state is still uninitialized	16 years ago
wireless	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next-2.6	15 years ago
x25	net/x25: push BKL usage into x25_proto	15 years ago
xfrm	xfrm: SAD entries do not expire correctly after suspend-resume	15 years ago
Kconfig	net/compat/wext: send different messages to compat tasks	16 years ago
Makefile	net: remove redundant sched/ in net/Makefile	16 years ago
TUNABLE	…
compat.c	net: Cleanup redundant tests on unsigned	15 years ago
nonet.c	…
socket.c	net/atm: move all compat_ioctl handling to atm/ioctl.c	15 years ago
sysctl_net.c	…