kernel_samsung_sm7125

jenna

History

Hugh Dickins 7c2c7d9930 fix setuid sometimes wouldn't check_unsafe_exec() also notes whether the fs_struct is being shared by more threads than will get killed by the exec, and if so sets LSM_UNSAFE_SHARE to make bprm_set_creds() careful about euid. But /proc/<pid>/cwd and /proc/<pid>/root lookups make transient use of get_fs_struct(), which also raises that sharing count. This might occasionally cause a setuid program not to change euid, in the same way as happened with files->count (check_unsafe_exec also looks at sighand->count, but /proc doesn't raise that one). We'd prefer exec not to unshare fs_struct: so fix this in procfs, replacing get_fs_struct() by get_fs_path(), which does path_get while still holding task_lock, instead of raising fs->count. Signed-off-by: Hugh Dickins <hugh@veritas.com> Cc: stable@kernel.org ___ fs/proc/base.c \| 50 +++++++++++++++-------------------------------- 1 file changed, 16 insertions(+), 34 deletions(-) Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		16 years ago
..
Kconfig	…
Makefile	proc: remove fs/proc/proc_misc.c	17 years ago
array.c	CRED: Use RCU to access another task's creds and to release a task's own creds	16 years ago
base.c	fix setuid sometimes wouldn't	16 years ago
cmdline.c	…
cpuinfo.c	…
devices.c	…
generic.c	constify dentry_operations: procfs	16 years ago
inode-alloc.txt	…
inode.c	proc: proc_get_inode should de_put when inode already initialized	16 years ago
internal.h	NOMMU: Make VMAs per MM as for MMU-mode linux	16 years ago
interrupts.c	…
kcore.c	…
kmsg.c	…
loadavg.c	…
meminfo.c	NOMMU: Make VMAs per MM as for MMU-mode linux	16 years ago
mmu.c	…
nommu.c	NOMMU: Make VMAs per MM as for MMU-mode linux	16 years ago
page.c	proc: fix kflags to uflags copying in /proc/kpageflags	16 years ago
proc_devtree.c	powerpc: Remove `have_of' global variable	16 years ago
proc_net.c	proc: stop using BKL	16 years ago
proc_sysctl.c	constify dentry_operations: procfs	16 years ago
proc_tty.c	…
root.c	vfs: simple_set_mnt() should return void	16 years ago
stat.c	proc: remove ifdef CONFIG_SPARSE_IRQ from stat.c	16 years ago
task_mmu.c	mm: report the MMU pagesize in /proc/pid/smaps	16 years ago
task_nommu.c	NOMMU: Improve procfs output using per-MM VMAs	16 years ago
uptime.c	proc: revert /proc/uptime to ->read_proc hook	17 years ago
version.c	…
vmcore.c	vmcore: remove saved_max_pfn check	16 years ago