You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

David Howells 7026f1929e FS-Cache: Handle removal of unadded object to the fscache_object_list rb tree ... When FS-Cache allocates an object, the following sequence of events can occur: -->fscache_alloc_object() -->cachefiles_alloc_object() [via cache->ops->alloc_object] <--[returns new object] -->fscache_attach_object() <--[failed] -->cachefiles_put_object() [via cache->ops->put_object] -->fscache_object_destroy() -->fscache_objlist_remove() -->rb_erase() to remove the object from fscache_object_list. resulting in a crash in the rbtree code. The problem is that the object is only added to fscache_object_list on the success path of fscache_attach_object() where it calls fscache_objlist_add(). So if fscache_attach_object() fails, the object won't have been added to the objlist rbtree. We do, however, unconditionally try to remove the object from the tree. Thanks to NeilBrown for finding this and suggesting this solution. Reported-by: NeilBrown <neilb@suse.de> Signed-off-by: David Howells <dhowells@redhat.com> Tested-by: (a customer of) NeilBrown <neilb@suse.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		11 years ago
..
Kconfig	…
Makefile	…
cache.c	FS-Cache: Fix object state machine to have separate work and wait states	12 years ago
cookie.c	FS-Cache: Provide the ability to enable/disable cookies	12 years ago
fsdef.c	FS-Cache: Provide the ability to enable/disable cookies	12 years ago
histogram.c	…
internal.h	FS-Cache: Add interface to check consistency of a cached object	12 years ago
main.c	FS-Cache: Simplify cookie retention for fscache_objects, fixing oops	12 years ago
netfs.c	FS-Cache: Provide the ability to enable/disable cookies	12 years ago
object-list.c	FS-Cache: Handle removal of unadded object to the fscache_object_list rb tree	11 years ago
object.c	FS-Cache: Handle removal of unadded object to the fscache_object_list rb tree	11 years ago
operation.c	FS-Cache: Don't use spin_is_locked() in assertions	12 years ago
page.c	FS-Cache: Provide the ability to enable/disable cookies	12 years ago
proc.c	…
stats.c	fs/fscache/stats.c: fix memory leak	12 years ago