You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Pete Zaitcev 51490c89f9 [SCSI] sr.c: Fix getting wrong size ... Here's the problem. Try to do this on 2.6.12: - Kill udev and HAL - Insert a CD-ROM into a SCSI or USB CD-ROM drive - Run dd if=/dev/scd0 - cat /sys/block/sr0/size - Eject the CD, insert a different one - Run dd if=/dev/scd0 This is likely to do "access beyond the end of device", if you let it - cat /sys/block/sr0/size This shows the size of a previous CD, even though dd was supposed to revalidate the device. - Run dd if=/dev/scd0 The second run of dd works correctly! The bug was introduced in 2.5.31, when Al fixes the recursive opens in partitioning. Before, the code worked like this: - Block layer called cdrom_open directly - cdrom_open called sr_open - sr_open called check_disk_change - check_disk_change called sr_media_change - sr_media_change did cd->needs_disk_change=1 - before returning sr_open tested cd->needs_disk_change and called get_sector_size. In 2.6.12, the check_disk_change is called from cdrom_open only. Thus: - Block layer calls sr_bd_open - sr_bd_open calls cdrom_open - cdrom_open calls sr_open - sr_open tests cd->needs_disk_change, which wasn't set yet; returns - cdrom_open calls check_disk_change - check_disk_change calls sr_media_change - sr_media_change does cd->needs_disk_change=1, but nobody cares Acked by: Alexander Viro <aviro@redhat.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>		20 years ago
..
acorn	…
acpi	…
atm	…
base	[SCSI] fix transport class corner case after rework	20 years ago
block	…
bluetooth	…
cdrom	…
char	[PATCH] agp: restore APBASE after setting APSIZE	20 years ago
cpufreq	…
crypto	…
dio	…
eisa	…
fc4	…
firmware	…
hwmon	[PATCH] I2C: use time_after in 3 chip drivers	20 years ago
i2c	[PATCH] I2C: 24RF08 corruption prevention (again)	20 years ago
ide	…
ieee1394	…
infiniband	…
input	Merge master.kernel.org:/pub/scm/linux/kernel/git/dtor/input	20 years ago
isdn	…
macintosh	…
mca	…
md	…
media	…
message	…
misc	…
mmc	…
mtd	…
net	…
nubus	…
oprofile	…
parisc	…
parport	…
pci	[PATCH] PCI: remove PCI_BRIDGE_CTL_VGA handling from setup-bus.c	20 years ago
pcmcia	…
pnp	…
s390	[PATCH] s390: device recognition	20 years ago
sbus	…
scsi	[SCSI] sr.c: Fix getting wrong size	20 years ago
serial	[PATCH] serial: add MMIO support to 8250_pnp	20 years ago
sh	…
sn	…
tc	…
telephony	…
usb	[PATCH] USB: hidinput_hid_event() oops fix	20 years ago
video	[PATCH] fbdev: Replace memcpy with for-loop when preparing bitmap	20 years ago
w1	[PATCH] w1: kconfig/Makefile fix.	20 years ago
zorro	…
Kconfig	…
Makefile	…