You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Andrew Morton 1aa9b4b9bc [PATCH] revert "retries in ext3_prepare_write() violate ordering requirements" ... Revert e92a4d595b. Dmitry points out "When we block_prepare_write() failed while ext3_prepare_write() we jump to "failure" label and call ext3_prepare_failure() witch search last mapped bh and invoke commit_write untill it. This is wrong!! because some bh from begining to the last mapped bh may be not uptodate. As a result we commit to disk not uptodate page content witch contains garbage from previous usage." and "Unexpected file size increasing." Call trace the same as it was in first issue but result is different. For example we have file with i_size is zero. we want write two blocks , but fs has only one free block. ->ext3_prepare_write(...from == 0, to == 2048) retry: ->block_prepare_write() == -ENOSPC# we failed but allocated one block here. ->ext3_prepare_failure() ->commit_write( from == 0, to == 1024) # after this i_size becomes 1024 :) if (ret == -ENOSPC && ext3_should_retry_alloc(inode->i_sb, &retries)) goto retry; Finally when all retries will be spended ext3_prepare_failure return -ENOSPC, but i_size was increased and later block trimm procedures can't help here. We don't appear to have the horsepower to fix these issues, so let's put things back the way they were for now. Cc: Kirill Korotaev <dev@openvz.org> Cc: Ingo Molnar <mingo@elte.hu> Cc: Ken Chen <kenneth.w.chen@intel.com> Cc: Andrey Savochkin <saw@sw.ru> Cc: <linux-ext4@vger.kernel.org> Cc: Dmitriy Monakhov <dmonakhov@openvz.org> Cc: <stable@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		18 years ago
..
Makefile	[PATCH] ext3: uninline large functions	18 years ago
acl.c	[PATCH] fs: Removing useless casts	19 years ago
acl.h	[PATCH] Remove leftover ext3 acl declarations	19 years ago
balloc.c	[PATCH] ext[234]: update documentation	18 years ago
bitmap.c	[PATCH] ext3 and jbd cleanup: remove whitespace	19 years ago
dir.c	[PATCH] ext3: change uses of f_{dentry, vfsmnt} to use f_path	18 years ago
ext3_jbd.c	[PATCH] ext3: uninline large functions	18 years ago
file.c	[PATCH] mark struct inode_operations const 1	18 years ago
fsync.c	[PATCH] ext3 and jbd cleanup: remove whitespace	19 years ago
hash.c	[PATCH] remove many unneeded #includes of sched.h	18 years ago
ialloc.c	[PATCH] inode-diet: Eliminate i_blksize from the inode structure	19 years ago
inode.c	[PATCH] revert "retries in ext3_prepare_write() violate ordering requirements"	18 years ago
ioctl.c	[PATCH] ext3: change uses of f_{dentry, vfsmnt} to use f_path	18 years ago
namei.c	[PATCH] mark struct inode_operations const 1	18 years ago
namei.h	[PATCH] ext3: sparse fixes	20 years ago
resize.c	[PATCH] remove many unneeded #includes of sched.h	18 years ago
super.c	[PATCH] Mark struct super_operations const	18 years ago
symlink.c	[PATCH] mark struct inode_operations const 1	18 years ago
xattr.c	[PATCH] "ext[34]: EA block reference count racing fix" performance fix	18 years ago
xattr.h	Remove obsolete #include <linux/config.h>	19 years ago
xattr_security.c	[PATCH] ext3: Enable atomic inode security labeling	20 years ago
xattr_trusted.c	[PATCH] capable/capability.h (fs/)	19 years ago
xattr_user.c	[PATCH] remove ext3 xattr permission checks	19 years ago