You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Grant Grundler 209261c019 [netdrvr] tulip_read_eeprom fixes for BUG 4420 ... If "location" is > "addr_len" bits, the high bits of location would interfere with the READ_CMD sent to the eeprom controller. A patch was submitted to bug: http://bugzilla.kernel.org/show_bug.cgi?id=4420 which simply truncated the "location", read whatever was in "location modulo addr_len", and returned that value. That avoids confusing the eeprom but seems like the wrong solution to me. Correct would be to not read beyond "1 << addr_len" address of the eeprom. I am submitting two changes to implement this: 1) tulip_read_eeprom will return zero (since we can't return -EINVAL) if this is attempted (defensive programming). 2) In tulip_core.c, fix the tulip_read_eeprom caller so they don't iterate past addr_len bits and make sure the entire tp->eeprom[] array is cleared. I konw we don't strictly need both. I would prefer both in the tree since it documents the issue and provides a second "defense" from the bug from creeping back in. Signed-off-by: Grant Grundler <grundler@parisc-linux.org> Signed-off-by: Jeff Garzik <jeff@garzik.org>		17 years ago
..
21142.c	PCI: Cleanup the includes of <linux/pci.h>	18 years ago
Kconfig	[NET]: Remove references to net-modules.txt.	18 years ago
Makefile	…
de4x5.c	[netdrvr] checkpatch cleanups	17 years ago
de4x5.h	more tulip endianness annotations	18 years ago
de2104x.c	2.6.25-rc4 de_stop_rxtx polling wrong	17 years ago
dmfe.c	[TULIP] DMFE: Fix SROM parsing regression.	17 years ago
eeprom.c	[netdrvr] tulip_read_eeprom fixes for BUG 4420	17 years ago
interrupt.c	[NET]: Do not check netif_running() and carrier state in ->poll()	17 years ago
media.c	…
pnic.c	PCI: Cleanup the includes of <linux/pci.h>	18 years ago
pnic2.c	PCI: Cleanup the includes of <linux/pci.h>	18 years ago
timer.c	PCI: Cleanup the includes of <linux/pci.h>	18 years ago
tulip.h	tulip: endianness annotations	18 years ago
tulip_core.c	[netdrvr] tulip_read_eeprom fixes for BUG 4420	17 years ago
uli526x.c	uli526x partially recognizing interface	17 years ago
winbond-840.c	Typo: depricated -> deprecated	18 years ago
xircom_cb.c	xircom_cb should return NETDEV_TX_BUSY when no descriptors available	17 years ago
xircom_tulip_cb.c	[NET]: Nuke SET_MODULE_OWNER macro.	18 years ago