You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Neil Horman dc5a144991 sis900: Allocate rx replacement buffer before rx operation ... Just found a hole in my last patch. It was reported to me that shortly after we integrated this patch. The report was of an oops that took place inside of netif_rx when using the sis900 driver. Looking at my origional patch I noted that there was a spot between the new skb_alloc and the refill_rx_ring label where skb got reassigned to the pointer currently held in the rx_ring for the purposes of receiveing the frame. The result of this is however that the buffer that gets passed to netif_rx (if it is called), then gets placed right back into the rx_ring. So if you receive frames fast enough the skb being processed by the network stack can get corrupted. The reporter is testing out the fix I've written for this below (I'm not near my hardware at the moment to test myself), but I wanted to post it for review ASAP. I'll post test results when I hear them, but I think this is a pretty straightforward fix. It just uses a separate pointer to do the rx operation, so that we don't improperly reassign the pointer that we use to refill the rx ring. Signed-off-by: Neil Horman <nhorman@tuxdriver.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>		18 years ago
..
appletalk	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
arcnet	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
arm	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
atl1	[NETDRV]: Perform missing csum_offset conversions	18 years ago
bonding	[NET]: Inline net_device_stats	18 years ago
chelsio	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
cris	[SK_BUFF]: Convert skb->end to sk_buff_data_t	18 years ago
cxgb3	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
e1000	Merge branch 'e1000-fixes' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6	18 years ago
ehea	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
fec_8xx	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
fs_enet	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
hamradio	[NET]: Fix yam.c	18 years ago
ibm_emac	[SK_BUFF]: Convert skb->tail to sk_buff_data_t	18 years ago
irda	[IrDA]: Adding carriage returns to mcs7780 debug statements	18 years ago
ixgb	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
ixp2000	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
myri10ge	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
netxen	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
pcmcia	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
phy	PHY: remove rwsem use from phy core	18 years ago
sk98lin	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
skfp	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
tokenring	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
tulip	Merge master.kernel.org:/pub/scm/linux/kernel/git/davem/sparc-2.6	18 years ago
wan	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
wireless	[WIRELESS] drivers/net/wireless/Kconfig: correct minor typo	18 years ago
3c59x.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
3c501.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
3c501.h	…
3c503.c	…
3c503.h	…
3c505.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
3c505.h	…
3c507.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
3c509.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
3c515.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
3c523.c	[NET]: Fix warnings in 3c523.c and ni52.c	18 years ago
3c523.h	…
3c527.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
3c527.h	…
7990.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
7990.h	…
8139cp.c	[SK_BUFF]: Introduce ip_hdr(), remove skb->nh.iph	18 years ago
8139too.c	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
8390.c	…
8390.h	…
82596.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
Kconfig	…
LICENSE.SRC	…
Makefile	[WIRELESS]: Refactor wireless Kconfig.	18 years ago
Space.c	…
a2065.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
a2065.h	…
ac3200.c	…
acenic.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
acenic.h	…
acenic_firmware.h	…
amd8111e.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
amd8111e.h	…
apne.c	…
ariadne.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
ariadne.h	…
at1700.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
atari_bionet.c	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
atari_pamsnet.c	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
atarilance.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
atp.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
atp.h	…
au1000_eth.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
au1000_eth.h	…
b44.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
b44.h	…
bmac.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
bmac.h	…
bnx2.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
bnx2.h	…
bnx2_fw.h	…
bnx2_fw2.h	…
bsd_comp.c	…
cassini.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
cassini.h	…
cs89x0.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
cs89x0.h	…
de600.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
de600.h	…
de620.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
de620.h	…
declance.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
defxx.c	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
defxx.h	…
depca.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
depca.h	…
dgrs.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
dgrs.h	…
dgrs_asstruct.h	…
dgrs_bcomm.h	…
dgrs_es4h.h	…
dgrs_ether.h	…
dgrs_firmware.c	…
dgrs_i82596.h	…
dgrs_plx9060.h	…
dl2k.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
dl2k.h	…
dm9000.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
dm9000.h	…
dummy.c	…
e100.c	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
e2100.c	…
eepro.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
eepro100.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
eexpress.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
eexpress.h	…
epic100.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
eql.c	…
es3210.c	…
eth16i.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
ewrk3.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
ewrk3.h	…
fealnx.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
fec.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
fec.h	…
forcedeth.c	[FORCEDETH]: Use skb_tailroom where appropriate	18 years ago
gianfar.c	[SK_BUFF]: Introduce skb_network_header_len	18 years ago
gianfar.h	…
gianfar_ethtool.c	…
gianfar_mii.c	…
gianfar_mii.h	…
gianfar_sysfs.c	…
hamachi.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
hp-plus.c	…
hp.c	…
hp100.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
hp100.h	…
hplance.c	…
hplance.h	…
hydra.c	…
ibmlana.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
ibmlana.h	…
ibmveth.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
ibmveth.h	…
ifb.c	…
ioc3-eth.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
isa-skeleton.c	…
iseries_veth.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
jazzsonic.c	…
lance.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
lasi_82596.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
lib8390.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
lne390.c	…
loopback.c	[NET]: loopback driver can use loopback_dev integrated net_device_stats	18 years ago
lp486e.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
mac89x0.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
mac8390.c	…
macb.c	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
macb.h	…
mace.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
mace.h	…
macmace.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
macsonic.c	…
meth.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
meth.h	…
mii.c	…
mipsnet.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
mipsnet.h	…
mv643xx_eth.c	[SK_BUFF]: Introduce tcp_hdr(), remove skb->h.th	18 years ago
mv643xx_eth.h	…
mvme147.c	…
myri_code.h	…
myri_sbus.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
myri_sbus.h	…
natsemi.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
ne-h8300.c	…
ne.c	…
ne2.c	…
ne2k-pci.c	…
ne3210.c	…
netconsole.c	…
netx-eth.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
ni52.c	[NET]: Fix warnings in 3c523.c and ni52.c	18 years ago
ni52.h	…
ni65.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
ni65.h	…
ni5010.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
ni5010.h	…
ns83820.c	[SK_BUFF]: Introduce ip_hdr(), remove skb->nh.iph	18 years ago
pasemi_mac.c	[SK_BUFF]: Introduce skb_network_header_len	18 years ago
pasemi_mac.h	…
pci-skeleton.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
pcnet32.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
plip.c	[SK_BUFF]: Introduce skb_mac_header()	18 years ago
ppp_async.c	…
ppp_deflate.c	…
ppp_generic.c	[NET]: ROUND_UP macro cleanup in drivers/net/ppp_generic.c	18 years ago
ppp_mppe.c	…
ppp_mppe.h	…
ppp_synctty.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
pppoe.c	[PPPOE]: Fix device tear-down notification.	18 years ago
pppox.c	[PPPOE]: memory leak when socket is release()d before PPPIOCGCHAN has been called on it	18 years ago
qla3xxx.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
qla3xxx.h	…
r8169.c	[SK_BUFF]: Introduce ip_hdr(), remove skb->nh.iph	18 years ago
rionet.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
rrunner.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
rrunner.h	…
s2io-regs.h	…
s2io.c	[SK_BUFF]: Convert skb->tail to sk_buff_data_t	18 years ago
s2io.h	…
saa9730.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
saa9730.h	…
sb1000.c	[SK_BUFF]: Introduce skb_reset_mac_header(skb)	18 years ago
sb1250-mac.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
sc92031.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
seeq8005.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
seeq8005.h	…
sgiseeq.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
sgiseeq.h	…
shaper.c	…
sis190.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
sis900.c	sis900: Allocate rx replacement buffer before rx operation	18 years ago
sis900.h	…
skge.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
skge.h	…
sky2.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
sky2.h	…
slhc.c	…
slip.c	[SK_BUFF]: Introduce skb_mac_header()	18 years ago
slip.h	…
smc-mca.c	…
smc-ultra.c	…
smc-ultra32.c	…
smc91x.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
smc91x.h	…
smc911x.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
smc911x.h	…
smc9194.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
smc9194.h	…
sonic.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
sonic.h	…
spider_net.c	[SK_BUFF]: Introduce ip_hdr(), remove skb->nh.iph	18 years ago
spider_net.h	…
spider_net_ethtool.c	…
starfire.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
starfire_firmware.h	…
starfire_firmware.pl	…
stnic.c	…
sun3_82586.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
sun3_82586.h	…
sun3lance.c	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	18 years ago
sunbmac.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
sunbmac.h	…
sundance.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
sungem.c	Merge master.kernel.org:/pub/scm/linux/kernel/git/davem/sparc-2.6	18 years ago
sungem.h	[SUNGEM]: Consolidate powerpc and sparc MAC probing code.	18 years ago
sungem_phy.c	…
sungem_phy.h	…
sunhme.c	Merge master.kernel.org:/pub/scm/linux/kernel/git/davem/sparc-2.6	18 years ago
sunhme.h	…
sunlance.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
sunqe.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
sunqe.h	…
tc35815.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
tg3.c	Merge master.kernel.org:/pub/scm/linux/kernel/git/davem/sparc-2.6	18 years ago
tg3.h	…
tlan.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
tlan.h	…
tsi108_eth.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
tsi108_eth.h	…
tun.c	[NET] tun/tap: fixed hw address handling	18 years ago
typhoon-firmware.h	…
typhoon.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
typhoon.h	…
ucc_geth.c	…
ucc_geth.h	…
ucc_geth_phy.c	…
ucc_geth_phy.h	…
via-rhine.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
via-velocity.c	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	18 years ago
via-velocity.h	…
wd.c	…
yellowfin.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
znet.c	[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans	18 years ago
zorro8390.c	…