You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Eric Sandeen d33a1976fb ext4: fix bb_prealloc_list corruption due to wrong group locking ... This is for Red Hat bug 490026: EXT4 panic, list corruption in ext4_mb_new_inode_pa ext4_lock_group(sb, group) is supposed to protect this list for each group, and a common code flow to remove an album is like this: ext4_get_group_no_and_offset(sb, pa->pa_pstart, &grp, NULL); ext4_lock_group(sb, grp); list_del(&pa->pa_group_list); ext4_unlock_group(sb, grp); so it's critical that we get the right group number back for this prealloc context, to lock the right group (the one associated with this pa) and prevent concurrent list manipulation. however, ext4_mb_put_pa() passes in (pa->pa_pstart - 1) with a comment, "-1 is to protect from crossing allocation group". This makes sense for the group_pa, where pa_pstart is advanced by the length which has been used (in ext4_mb_release_context()), and when the entire length has been used, pa_pstart has been advanced to the first block of the next group. However, for inode_pa, pa_pstart is never advanced; it's just set once to the first block in the group and not moved after that. So in this case, if we subtract one in ext4_mb_put_pa(), we are actually locking the *previous* group, and opening the race with the other threads which do not subtract off the extra block. Signed-off-by: Eric Sandeen <sandeen@redhat.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>		16 years ago
..
Kconfig	fs/Kconfig: move ext2, ext3, ext4, JBD, JBD2 out	16 years ago
Makefile	ext4: Rename ext4dev to ext4	16 years ago
acl.c	…
acl.h	ext4: Rename ext4dev to ext4	16 years ago
balloc.c	ext4: don't call jbd2_journal_force_commit_nested without journal	16 years ago
bitmap.c	ext4: Change unsigned long to unsigned int	16 years ago
dir.c	ext4: Make printk's consistently prefixed with "EXT4-fs: "	16 years ago
ext4.h	ext4: Fix to read empty directory blocks correctly in 64k	16 years ago
ext4_extents.h	ext4: Remove i_ext_generation from ext4_inode_info structure	16 years ago
ext4_i.h	ext4: Make ext4_group_t be an unsigned int	16 years ago
ext4_jbd2.c	ext4: Allow ext4 to run without a journal	16 years ago
ext4_jbd2.h	ext4: Remove "extents" mount option	16 years ago
ext4_sb.h	fs: introduce bgl_lock_ptr()	16 years ago
extents.c	ext4: fix header check in ext4_ext_search_right() for deep extent trees.	16 years ago
file.c	ext4: sparse fixes	16 years ago
fsync.c	ext4: Add debugging markers that can be used by systemtap	17 years ago
group.h	…
hash.c	ext4: Add support for non-native signed/unsigned htree hash algorithms	16 years ago
ialloc.c	ext4: Print the find_group_flex() warning only once	16 years ago
inode.c	ext4: don't call jbd2_journal_force_commit_nested without journal	16 years ago
ioctl.c	ext4: Allow ext4 to run without a journal	16 years ago
mballoc.c	ext4: fix bb_prealloc_list corruption due to wrong group locking	16 years ago
mballoc.h	ext4: Don't allow new groups to be added during block allocation	16 years ago
migrate.c	ext4: Fix NULL dereference in ext4_ext_migrate()'s error handling	16 years ago
namei.c	ext4: Add sanity check to make_indexed_dir	16 years ago
namei.h	…
resize.c	ext4: Initialize the new group descriptor when resizing the filesystem	16 years ago
super.c	ext4: Remove duplicate call to ext4_commit_super() in ext4_freeze()	16 years ago
symlink.c	ext4: Rename ext4dev to ext4	16 years ago
xattr.c	ext4: Allow ext4 to run without a journal	16 years ago
xattr.h	ext4: Rename ext4dev to ext4	16 years ago
xattr_security.c	…
xattr_trusted.c	…
xattr_user.c	…