You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Brian Haley bf0b48dfc3 [IPv6]: Fix ICMPv6 redirect handling with target multicast address ... When the ICMPv6 Target address is multicast, Linux processes the redirect instead of dropping it. The problem is in this code in ndisc_redirect_rcv(): if (ipv6_addr_equal(dest, target)) { on_link = 1; } else if (!(ipv6_addr_type(target) & IPV6_ADDR_LINKLOCAL)) { ND_PRINTK2(KERN_WARNING "ICMPv6 Redirect: target address is not link-local.\n"); return; } This second check will succeed if the Target address is, for example, FF02::1 because it has link-local scope. Instead, it should be checking if it's a unicast link-local address, as stated in RFC 2461/4861 Section 8.1: - The ICMP Target Address is either a link-local address (when redirected to a router) or the same as the ICMP Destination Address (when redirected to the on-link destination). I know this doesn't explicitly say unicast link-local address, but it's implied. This bug is preventing Linux kernels from achieving IPv6 Logo Phase II certification because of a recent error that was found in the TAHI test suite - Neighbor Disovery suite test 206 (v6LC.2.3.6_G) had the multicast address in the Destination field instead of Target field, so we were passing the test. This won't be the case anymore. The patch below fixes this problem, and also fixes ndisc_send_redirect() to not send an invalid redirect with a multicast address in the Target field. I re-ran the TAHI Neighbor Discovery section to make sure Linux passes all 245 tests now. Signed-off-by: Brian Haley <brian.haley@hp.com> Acked-by: David L Stevens <dlstevens@us.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>		18 years ago
..
9p	9p: fix bad error path in conversion routines	18 years ago
802	[SNAP]: Check packet length before reading	18 years ago
8021q	[VLAN]: Fix net_device leak.	18 years ago
appletalk	…
atm	[ATM]: Clean up duplicate includes in net/atm/	18 years ago
ax25	[AX25]: don't free pointers to statically allocated data	18 years ago
bluetooth	[BLUETOOTH]: Fix non-COMPAT build of hci_sock.c	18 years ago
bridge	[NET] skbuff: Add skb_cow_head	18 years ago
core	[PKTGEN]: srcmac fix	18 years ago
dccp	[DCCP]: Allocation in atomic context	18 years ago
decnet	[DECNET]: Fix interface address listing regression.	18 years ago
econet	[ECONET]: remove econet_packet_type on unload	18 years ago
ethernet	…
ieee80211	Merge branch 'fixes-jgarzik' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6 into upstream-fixes	18 years ago
ipv4	[TCP]: Fix fastpath_cnt_hint when GSO skb is partially ACKed	18 years ago
ipv6	[IPv6]: Fix ICMPv6 redirect handling with target multicast address	18 years ago
ipx	…
irda	[IRDA] irda_nl_get_mode: always results in failure	18 years ago
iucv	…
key	[PF_KEY]: Fix ipsec not working in 2.6.23-rc1-git10	18 years ago
lapb	…
llc	…
mac80211	[PATCH] mac80211: fix initialisation when built-in	18 years ago
netfilter	[NETFILTER]: nfnetlink_log: fix sending of multipart messages	18 years ago
netlabel	[NetLabel]: add missing rcu_dereference() calls in the LSM domain mapping hash table	18 years ago
netlink	…
netrom	…
packet	…
rfkill	…
rose	[ROSE]: Fix rose.ko oops on unload	18 years ago
rxrpc	…
sched	[PKT_SCHED] cls_u32: error code isn't been propogated properly	18 years ago
sctp	fix sctp_del_bind_addr() last argument type	18 years ago
sunrpc	rpc: fix garbage in printk in svc_tcp_accept()	18 years ago
tipc	[TIPC]: Clean up duplicate includes in net/tipc/	18 years ago
unix	…
wanrouter	…
wireless	[PATCH] cfg80211: fix initialisation if built-in	18 years ago
x25	…
xfrm	[XFRM]: Clean up duplicate includes in net/xfrm/	18 years ago
Kconfig	…
Makefile	…
TUNABLE	…
compat.c	…
nonet.c	…
socket.c	[NET]: Zero length write() on socket should not simply return 0.	18 years ago
sysctl_net.c	…