You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Jiri Pirko 859828c0ea br: fix use of ->rx_handler_data in code executed on non-rx_handler path ... br_stp_rcv() is reached by non-rx_handler path. That means there is no guarantee that dev is bridge port and therefore simple NULL check of ->rx_handler_data is not enough. There is need to check if dev is really bridge port and since only rcu read lock is held here, do it by checking ->rx_handler pointer. Note that synchronize_net() in netdev_rx_handler_unregister() ensures this approach as valid. Introduced originally by: commit f350a0a873 "bridge: use rx_handler_data pointer to store net_bridge_port pointer" Fixed but not in the best way by: commit b5ed54e94d "bridge: fix RCU races with bridge port" Reintroduced by: commit 716ec052d2 "bridge: fix NULL pointer deref of br_port_get_rcu" Please apply to stable trees as well. Thanks. RH bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id=1025770 Reported-by: Laine Stump <laine@redhat.com> Debugged-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Jiri Pirko <jiri@resnulli.us> Acked-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		11 years ago
..
netfilter	netfilter: ebt_ip6: fix source and destination matching	11 years ago
Kconfig	bridge: Add vlan filtering infrastructure	12 years ago
Makefile	bridge: Add vlan filtering infrastructure	12 years ago
br.c	net:bridge: use IS_ENABLED	13 years ago
br_device.c	Merge branch 'core-locking-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	11 years ago
br_fdb.c	bridge: Don't use VID 0 and 4095 in vlan filtering	11 years ago
br_forward.c	bridge: Add a flag to control unicast packet flood.	12 years ago
br_if.c	bridge: flush br's address entry in fdb when remove the	11 years ago
br_input.c	bridge: pass correct vlan id to multicast code	11 years ago
br_ioctl.c	net: Allow userns root to control the network bridge code.	12 years ago
br_mdb.c	Revert "bridge: only expire the mdb entry when query is received"	11 years ago
br_multicast.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	11 years ago
br_netfilter.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	11 years ago
br_netlink.c	bridge: Don't use VID 0 and 4095 in vlan filtering	11 years ago
br_notify.c	net: convert resend IGMP to notifier event	12 years ago
br_private.h	br: fix use of ->rx_handler_data in code executed on non-rx_handler path	11 years ago
br_private_stp.h	net: 8021q/bluetooth/bridge/can/ceph: Remove extern from function prototypes	11 years ago
br_stp.c	bridge: Clamp forward_delay when enabling STP	12 years ago
br_stp_bpdu.c	br: fix use of ->rx_handler_data in code executed on non-rx_handler path	11 years ago
br_stp_if.c	bridge: Correctly clamp MAX forward_delay when enabling STP	11 years ago
br_stp_timer.c	bridge: fix race with topology change timer	12 years ago
br_sysfs_br.c	bridge: correct the comment for file br_sysfs_br.c	12 years ago
br_sysfs_if.c	bridge: Add a flag to control unicast packet flood.	12 years ago
br_vlan.c	bridge: Call vlan_vid_del for all vids at nbp_vlan_flush	11 years ago