You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Jan Kara 35e481761c fsnotify: avoid spurious EMFILE errors from inotify_init() ... Inotify instance is destroyed when all references to it are dropped. That not only means that the corresponding file descriptor needs to be closed but also that all corresponding instance marks are freed (as each mark holds a reference to the inotify instance). However marks are freed only after SRCU period ends which can take some time and thus if user rapidly creates and frees inotify instances, number of existing inotify instances can exceed max_user_instances limit although from user point of view there is always at most one existing instance. Thus inotify_init() returns EMFILE error which is hard to justify from user point of view. This problem is exposed by LTP inotify06 testcase on some machines. We fix the problem by making sure all group marks are properly freed while destroying inotify instance. We wait for SRCU period to end in that path anyway since we have to make sure there is no event being added to the instance while we are tearing down the instance. So it takes only some plumbing to allow for marks to be destroyed in that path as well and not from a dedicated work item. [akpm@linux-foundation.org: coding-style fixes] Signed-off-by: Jan Kara <jack@suse.cz> Reported-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com> Tested-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		9 years ago
..
dnotify	fsnotify: get rid of fsnotify_destroy_mark_locked()	10 years ago
fanotify	fsnotify: get rid of fsnotify_destroy_mark_locked()	10 years ago
inotify	inotify: actually check for invalid bits in sys_inotify_add_watch()	9 years ago
Kconfig	rcu: Make SRCU optional by using CONFIG_SRCU	10 years ago
Makefile	fs, notify: add procfs fdinfo helper	12 years ago
fdinfo.c	inotify: hide internal kernel bits from fdinfo	9 years ago
fdinfo.h	fs: Convert show_fdinfo functions to void	10 years ago
fsnotify.c	fsnotify: remove mark->free_list	10 years ago
fsnotify.h	fsnotify: avoid spurious EMFILE errors from inotify_init()	9 years ago
group.c	fsnotify: avoid spurious EMFILE errors from inotify_init()	9 years ago
inode_mark.c	fs/notify/inode_mark.c: use list_next_entry in fsnotify_unmount_inodes	9 years ago
mark.c	fsnotify: avoid spurious EMFILE errors from inotify_init()	9 years ago
notification.c	fanotify: fix double free of pending permission events	11 years ago
vfsmount_mark.c	fsnotify: remove mark->free_list	10 years ago