You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Hugh Dickins 2fd4ef85e0 [PATCH] error path in setup_arg_pages() misses vm_unacct_memory() ... Pavel Emelianov and Kirill Korotaev observe that fs and arch users of security_vm_enough_memory tend to forget to vm_unacct_memory when a failure occurs further down (typically in setup_arg_pages variants). These are all users of insert_vm_struct, and that reservation will only be unaccounted on exit if the vma is marked VM_ACCOUNT: which in some cases it is (hidden inside VM_STACK_FLAGS) and in some cases it isn't. So x86_64 32-bit and ppc64 vDSO ELFs have been leaking memory into Committed_AS each time they're run. But don't add VM_ACCOUNT to them, it's inappropriate to reserve against the very unlikely case that gdb be used to COW a vDSO page - we ought to do something about that in do_wp_page, but there are yet other inconsistencies to be resolved. The safe and economical way to fix this is to let insert_vm_struct do the security_vm_enough_memory check when it finds VM_ACCOUNT is set. And the MIPS irix_brk has been calling security_vm_enough_memory before calling do_brk which repeats it, doubly accounting and so also leaking. Remove that, and all the fs and arch calls to security_vm_enough_memory: give it a less misleading name later on. Signed-off-by: Hugh Dickins <hugh@veritas.com> Signed-Off-By: Kirill Korotaev <dev@sw.ru> Signed-off-by: Linus Torvalds <torvalds@osdl.org>		20 years ago
..
Makefile	[PATCH] mips: clean up 32/64-bit configuration	20 years ago
asm-offsets.c	mips: rename offsets.c to asm-offsets.c	20 years ago
binfmt_elfn32.c	[PATCH] mips: nuke trailing whitespace	20 years ago
binfmt_elfo32.c	[PATCH] mips: nuke trailing whitespace	20 years ago
branch.c	Linux-2.6.12-rc2	20 years ago
cpu-bugs64.c	[PATCH] mips: nuke trailing whitespace	20 years ago
cpu-probe.c	[PATCH] more vr4181 removal	20 years ago
entry.S	Linux-2.6.12-rc2	20 years ago
gdb-low.S	[PATCH] mips: clean up 32/64-bit configuration	20 years ago
gdb-stub.c	[PATCH] mips: nuke trailing whitespace	20 years ago
genex.S	[PATCH] mips: fix build warnings	20 years ago
genrtc.c	[PATCH] more SPIN_LOCK_UNLOCKED -> DEFINE_SPINLOCK conversions	20 years ago
head.S	[PATCH] mips: clean up 32/64-bit configuration	20 years ago
i8259.c	[PATCH] more SPIN_LOCK_UNLOCKED -> DEFINE_SPINLOCK conversions	20 years ago
init_task.c	Linux-2.6.12-rc2	20 years ago
ioctl32.c	[PATCH] mips: nuke trailing whitespace	20 years ago
irix5sys.S	Linux-2.6.12-rc2	20 years ago
irixelf.c	Linux-2.6.12-rc2	20 years ago
irixinv.c	Linux-2.6.12-rc2	20 years ago
irixioctl.c	[PATCH] files: lock-free fd look-up	20 years ago
irixsig.c	[PATCH] mips: fix-up schedule_timeout() usage	20 years ago
irq-msc01.c	Linux-2.6.12-rc2	20 years ago
irq-mv6434x.c	Linux-2.6.12-rc2	20 years ago
irq-rm7000.c	Linux-2.6.12-rc2	20 years ago
irq-rm9000.c	Linux-2.6.12-rc2	20 years ago
irq.c	[PATCH] mips: nuke trailing whitespace	20 years ago
irq_cpu.c	Linux-2.6.12-rc2	20 years ago
linux32.c	[PATCH] compat: be more consistent about [ug]id_t	20 years ago
mips_ksyms.c	[PATCH] mips: clean up 32/64-bit configuration	20 years ago
module-elf32.c	Linux-2.6.12-rc2	20 years ago
module-elf64.c	Linux-2.6.12-rc2	20 years ago
module.c	Linux-2.6.12-rc2	20 years ago
proc.c	Linux-2.6.12-rc2	20 years ago
process.c	[PATCH] mips: clean up 32/64-bit configuration	20 years ago
ptrace.c	[PATCH] mips: clean up 32/64-bit configuration	20 years ago
ptrace32.c	[PATCH] convert that currently tests _NSIG directly to use valid_signal()	20 years ago
r4k_fpu.S	kbuild: mips use generic asm-offsets.h support	20 years ago
r4k_switch.S	kbuild: mips use generic asm-offsets.h support	20 years ago
r2300_fpu.S	kbuild: mips use generic asm-offsets.h support	20 years ago
r2300_switch.S	kbuild: mips use generic asm-offsets.h support	20 years ago
r6000_fpu.S	kbuild: mips use generic asm-offsets.h support	20 years ago
reset.c	[PATCH] Don't export machine_restart, machine_halt, or machine_power_off.	20 years ago
scall32-o32.S	kbuild: mips use generic asm-offsets.h support	20 years ago
scall64-64.S	kbuild: mips use generic asm-offsets.h support	20 years ago
scall64-n32.S	Linux-2.6.12-rc2	20 years ago
scall64-o32.S	Linux-2.6.12-rc2	20 years ago
semaphore.c	Linux-2.6.12-rc2	20 years ago
setup.c	[PATCH] mips: clean up 32/64-bit configuration	20 years ago
signal-common.h	Linux-2.6.12-rc2	20 years ago
signal.c	[PATCH] convert signal handling of NODEFER to act like other Unix boxes.	20 years ago
signal32.c	[PATCH] mips: nuke trailing whitespace	20 years ago
signal_n32.c	Linux-2.6.12-rc2	20 years ago
smp.c	Linux-2.6.12-rc2	20 years ago
syscall.c	kbuild: mips use generic asm-offsets.h support	20 years ago
sysirix.c	[PATCH] error path in setup_arg_pages() misses vm_unacct_memory()	20 years ago
time.c	[PATCH] NTP: ntp-helper functions	20 years ago
traps.c	[PATCH] mips: clean up 32/64-bit configuration	20 years ago
unaligned.c	[PATCH] mips: clean up 32/64-bit configuration	20 years ago
vmlinux.lds.S	[PATCH] mips: nuke trailing whitespace	20 years ago