You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Jason Wang f663dd9aaf net: core: explicitly select a txq before doing l2 forwarding ... Currently, the tx queue were selected implicitly in ndo_dfwd_start_xmit(). The will cause several issues: - NETIF_F_LLTX were removed for macvlan, so txq lock were done for macvlan instead of lower device which misses the necessary txq synchronization for lower device such as txq stopping or frozen required by dev watchdog or control path. - dev_hard_start_xmit() was called with NULL txq which bypasses the net device watchdog. - dev_hard_start_xmit() does not check txq everywhere which will lead a crash when tso is disabled for lower device. Fix this by explicitly introducing a new param for .ndo_select_queue() for just selecting queues in the case of l2 forwarding offload. netdev_pick_tx() was also extended to accept this parameter and dev_queue_xmit_accel() was used to do l2 forwarding transmission. With this fixes, NETIF_F_LLTX could be preserved for macvlan and there's no need to check txq against NULL in dev_hard_start_xmit(). Also there's no need to keep a dedicated ndo_dfwd_start_xmit() and we can just reuse the code of dev_queue_xmit() to do the transmission. In the future, it was also required for macvtap l2 forwarding support since it provides a necessary synchronization method. Cc: John Fastabend <john.r.fastabend@intel.com> Cc: Neil Horman <nhorman@tuxdriver.com> Cc: e1000-devel@lists.sourceforge.net Signed-off-by: Jason Wang <jasowang@redhat.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> Acked-by: John Fastabend <john.r.fastabend@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>		11 years ago
..
acpi	Merge branches 'acpi-pci-pm' and 'acpi-pci-hotplug'	11 years ago
asm-generic	mm: Fix NULL pointer dereference in madvise(MADV_WILLNEED) support	11 years ago
clocksource	…
crypto	crypto: scatterwalk - Use sg_chain_ptr on chain entries	11 years ago
drm	drm/radeon: 0x9649 is SUMO2 not SUMO	11 years ago
dt-bindings	For the 3.13 merge window we have a couple of new drivers for the AMS	11 years ago
keys	…
kvm	…
linux	net: core: explicitly select a txq before doing l2 forwarding	11 years ago
math-emu	…
media	[media] videobuf2: Add support for file access mode flags for DMABUF exporting	11 years ago
memory	…
misc	…
net	sctp: Remove outqueue empty state	11 years ago
pcmcia	…
ras	…
rdma	IB/core: const'ify inbuf in struct ib_udata	11 years ago
rxrpc	…
scsi	[SCSI] Disable WRITE SAME for RAID and virtual host adapter drivers	11 years ago
sound	ALSA: memalloc.h - fix wrong truncation of dma_addr_t	11 years ago
target	target/file: Update hw_max_sectors based on current block_size	11 years ago
trace	Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	11 years ago
uapi	Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux	11 years ago
video	fbdev changes for 3.13	11 years ago
xen	Bug-fixes:	11 years ago
Kbuild	…