You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Alex Elder 14d2f38df6 libceph: must hold mutex for reset_changed_osds() ... An osd client has a red-black tree describing its osds, and occasionally we would get crashes due to one of these trees tree becoming corrupt somehow. The problem turned out to be that reset_changed_osds() was being called without protection of the osd client request mutex. That function would call __reset_osd() for any osd that had changed, and __reset_osd() would call __remove_osd() for any osd with no outstanding requests, and finally __remove_osd() would remove the corresponding entry from the red-black tree. Thus, the tree was getting modified without having any lock protection, and was vulnerable to problems due to concurrent updates. This appears to be the only osd tree updating path that has this problem. It can be fairly easily fixed by moving the call up a few lines, to just before the request mutex gets dropped in kick_requests(). This resolves: http://tracker.ceph.com/issues/5043 Cc: stable@vger.kernel.org # 3.4+ Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Sage Weil <sage@inktank.com>		12 years ago
..
crush	crush: avoid recursion if we have already collided	12 years ago
Kconfig	net/ceph: remove depends on CONFIG_EXPERIMENTAL	12 years ago
Makefile	libceph: create source file "net/ceph/snapshot.c"	12 years ago
armor.c	libceph: Fix base64-decoding when input ends in newline.	14 years ago
auth.c	libceph: wrap auth methods in a mutex	12 years ago
auth_none.c	ceph: messenger: reduce args to create_authorizer	13 years ago
auth_none.h	…
auth_x.c	libceph: wrap auth ops in wrapper functions	12 years ago
auth_x.h	libceph: add update_authorizer auth method	12 years ago
auth_x_protocol.h	…
buffer.c	net: allow GFP_HIGHMEM in __vmalloc()	14 years ago
ceph_common.c	libceph: use slab cache for osd client requests	12 years ago
ceph_fs.c	ceph: fix file mode calculation	14 years ago
ceph_hash.c	net: cleanup unsigned to unsigned int	13 years ago
ceph_strings.c	libceph: update ceph_osd_op_name()	12 years ago
crypto.c	libceph: eliminate sparse warnings	12 years ago
crypto.h	libceph: fix crypto key null deref, memory leak	13 years ago
debugfs.c	libceph: keep source rather than message osd op array	12 years ago
messenger.c	libceph: allocate ceph message data with a slab allocator	12 years ago
mon_client.c	libceph: wrap auth ops in wrapper functions	12 years ago
msgpool.c	libceph: initialize msgpool message types	13 years ago
osd_client.c	libceph: must hold mutex for reset_changed_osds()	12 years ago
osdmap.c	libceph: define ceph_decode_pgid() only once	12 years ago
pagelist.c	ceph: use list_move_tail instead of list_del/list_add_tail	13 years ago
pagevec.c	libceph: drop return value from page vector copy routines	12 years ago
snapshot.c	libceph: create source file "net/ceph/snapshot.c"	12 years ago