You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

David Howells 12debc4248 iget: remove iget() and the read_inode() super op as being obsolete ... Remove the old iget() call and the read_inode() superblock operation it uses as these are really obsolete, and the use of read_inode() does not produce proper error handling (no distinction between ENOMEM and EIO when marking an inode bad). Furthermore, this removes the temptation to use iget() to find an inode by number in a filesystem from code outside that filesystem. iget_locked() should be used instead. A new function is added in an earlier patch (iget_failed) that is to be called to mark an inode as bad, unlock it and release it should the get routine fail. Mark iget() and read_inode() as being obsolete and remove references to them from the documentation. Typically a filesystem will be modified such that the read_inode function becomes an internal iget function, for example the following: void thingyfs_read_inode(struct inode *inode) { ... } would be changed into something like: struct inode *thingyfs_iget(struct super_block *sp, unsigned long ino) { struct inode *inode; int ret; inode = iget_locked(sb, ino); if (!inode) return ERR_PTR(-ENOMEM); if (!(inode->i_state & I_NEW)) return inode; ... unlock_new_inode(inode); return inode; error: iget_failed(inode); return ERR_PTR(ret); } and then thingyfs_iget() would be called rather than iget(), for example: ret = -EINVAL; inode = iget(sb, ino); if (!inode || is_bad_inode(inode)) goto error; becomes: inode = thingyfs_iget(sb, ino); if (IS_ERR(inode)) { ret = PTR_ERR(inode); goto error; } Note that is_bad_inode() does not need to be called. The error returned by thingyfs_iget() should render it unnecessary. Signed-off-by: David Howells <dhowells@redhat.com> Acked-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		17 years ago
..
configfs	correct missing a double quote in configfs.txt	17 years ago
00-INDEX	Documentation: move sharedsubtrees.txt to filesystems/	17 years ago
9p.txt	9p: add virtio transport	17 years ago
Exporting	exportfs: update documentation	17 years ago
Locking	iget: remove iget() and the read_inode() super op as being obsolete	17 years ago
adfs.txt	…
affs.txt	…
afs.txt	…
automount-support.txt	…
befs.txt	…
bfs.txt	…
cifs.txt	…
coda.txt	…
cramfs.txt	…
dentry-locking.txt	…
directory-locking	…
dlmfs.txt	…
dnotify.txt	Documentation: move dnotify.txt to filesystems/	17 years ago
ecryptfs.txt	…
ext2.txt	…
ext3.txt	documentation/ext3: grammar fixes	17 years ago
ext4.txt	ext4: Add multi block allocator for ext4	17 years ago
files.txt	…
fuse.txt	…
gfs2.txt	…
hfs.txt	…
hfsplus.txt	…
hpfs.txt	…
inotify.txt	…
isofs.txt	…
jfs.txt	…
locks.txt	…
mandatory-locking.txt	…
ncpfs.txt	…
ntfs.txt	…
ocfs2.txt	[PATCH 2/2] ocfs2: cluster aware flock()	17 years ago
porting	iget: remove iget() and the read_inode() super op as being obsolete	17 years ago
proc.txt	get rid of NR_OPEN and introduce a sysctl_nr_open	17 years ago
quota.txt	…
ramfs-rootfs-initramfs.txt	Documentation: fix type error	17 years ago
relay.txt	doc: use correct debugfs mountpoint	17 years ago
romfs.txt	…
sharedsubtree.txt	Documentation: move sharedsubtrees.txt to filesystems/	17 years ago
smbfs.txt	…
spufs.txt	…
sysfs-pci.txt	…
sysfs.txt	docs/sysfs: add missing word to sysfs attribute explanation	17 years ago
sysv-fs.txt	…
tmpfs.txt	…
udf.txt	…
ufs.txt	…
vfat.txt	…
vfs.txt	iget: remove iget() and the read_inode() super op as being obsolete	17 years ago
xfs.txt	…
xip.txt	…