You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

John Heffner 5528e568a7 [TCP]: Fix snd_cwnd adjustments in tcp_highspeed.c ... Xiaoliang (David) Wei wrote: > Hi gurus, > > I am reading the code of tcp_highspeed.c in the kernel and have a > question on the hstcp_cong_avoid function, specifically the following > AI part (line 136~143 in net/ipv4/tcp_highspeed.c ): > > /* Do additive increase */ > if (tp->snd_cwnd < tp->snd_cwnd_clamp) { > tp->snd_cwnd_cnt += ca->ai; > if (tp->snd_cwnd_cnt >= tp->snd_cwnd) { > tp->snd_cwnd++; > tp->snd_cwnd_cnt -= tp->snd_cwnd; > } > } > > In this part, when (tp->snd_cwnd_cnt == tp->snd_cwnd), > snd_cwnd_cnt will be -1... snd_cwnd_cnt is defined as u16, will this > small chance of getting -1 becomes a problem? > Shall we change it by reversing the order of the cwnd++ and cwnd_cnt -= > cwnd? Absolutely correct. Thanks. Signed-off-by: John Heffner <jheffner@psc.edu> Signed-off-by: David S. Miller <davem@davemloft.net>		19 years ago
..
802	…
8021q	…
appletalk	…
atm	…
ax25	[AX.25]: Eleminate HZ from AX.25 kernel interfaces	19 years ago
bluetooth	…
bridge	[BRIDGE]: keep track of received multicast packets	19 years ago
core	…
dccp	[DCCP]: Fix sock_orphan dead lock	19 years ago
decnet	[DECNET]: Fix level1 router hello	19 years ago
econet	…
ethernet	…
ieee80211	…
ipv4	[TCP]: Fix snd_cwnd adjustments in tcp_highspeed.c	19 years ago
ipv6	…
ipx	…
irda	…
key	…
lapb	…
llc	…
netfilter	[NETFILTER]: x_tables: don't use __copy_{from,to}_user on unchecked memory in compat layer	19 years ago
netlink	Merge branch 'audit.b10' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/audit-current	19 years ago
netrom	[NETROM/ROSE]: Kill module init version kernel log messages.	19 years ago
packet	…
rose	[NETROM/ROSE]: Kill module init version kernel log messages.	19 years ago
rxrpc	…
sched	…
sctp	[SCTP]: Fix state table entries for chunks received in CLOSED state.	19 years ago
sunrpc	…
tipc	…
unix	…
wanrouter	…
x25	…
xfrm	…
Kconfig	…
Makefile	…
TUNABLE	…
compat.c	…
nonet.c	…
socket.c	…
sysctl_net.c	…