You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Eric W. Biederman 7f78e03513 fs: Limit sys_mount to only request filesystem modules. ... Modify the request_module to prefix the file system type with "fs-" and add aliases to all of the filesystems that can be built as modules to match. A common practice is to build all of the kernel code and leave code that is not commonly needed as modules, with the result that many users are exposed to any bug anywhere in the kernel. Looking for filesystems with a fs- prefix limits the pool of possible modules that can be loaded by mount to just filesystems trivially making things safer with no real cost. Using aliases means user space can control the policy of which filesystem modules are auto-loaded by editing /etc/modprobe.d/*.conf with blacklist and alias directives. Allowing simple, safe, well understood work-arounds to known problematic software. This also addresses a rare but unfortunate problem where the filesystem name is not the same as it's module name and module auto-loading would not work. While writing this patch I saw a handful of such cases. The most significant being autofs that lives in the module autofs4. This is relevant to user namespaces because we can reach the request module in get_fs_type() without having any special permissions, and people get uncomfortable when a user specified string (in this case the filesystem type) goes all of the way to request_module. After having looked at this issue I don't think there is any particular reason to perform any filtering or permission checks beyond making it clear in the module request that we want a filesystem module. The common pattern in the kernel is to call request_module() without regards to the users permissions. In general all a filesystem module does once loaded is call register_filesystem() and go to sleep. Which means there is not much attack surface exposed by loading a filesytem module unless the filesystem is mounted. In a user namespace filesystems are not mounted unless .fs_flags = FS_USERNS_MOUNT, which most filesystems do not set today. Acked-by: Serge Hallyn <serge.hallyn@canonical.com> Acked-by: Kees Cook <keescook@chromium.org> Reported-by: Kees Cook <keescook@google.com> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>		12 years ago
..
Kconfig	fs/hfs: remove depends on CONFIG_EXPERIMENTAL	12 years ago
Makefile	…
attr.c	…
bfind.c	hfs: Convert tree_lock to mutex	15 years ago
bitmap.c	hfs: convert bitmap_lock in a mutex	17 years ago
bnode.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	15 years ago
brec.c	…
btree.c	hfs: fix hfs_find_init() sb->ext_tree NULL ptr oops	13 years ago
btree.h	hfs: Convert tree_lock to mutex	15 years ago
catalog.c	hfs: fix a potential buffer overflow	15 years ago
dir.c	new helper: file_inode(file)	12 years ago
extent.c	hfs: get rid of hfs_sync_super	13 years ago
hfs.h	…
hfs_fs.h	userns: Convert hfs to use kuid and kgid where appropriate	13 years ago
inode.c	new helper: file_inode(file)	12 years ago
mdb.c	hfs: nuke write_super from comments	13 years ago
part_tbl.c	…
string.c	fs: change d_hash for rcu-walk	14 years ago
super.c	fs: Limit sys_mount to only request filesystem modules.	12 years ago
sysdep.c	stop passing nameidata * to ->d_revalidate()	13 years ago
trans.c	hfs: add sanity check for file name length	13 years ago