You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Shyam Iyer 71b3346d18 net: Fix OOPS in skb_seq_read(). ... It oopsd for me in skb_seq_read. addr2line said it was linux-2.6/net/core/skbuff.c:2228, which is this line: while (st->frag_idx < skb_shinfo(st->cur_skb)->nr_frags) { I added some printks in there and it looks like we hit this: } else if (st->root_skb == st->cur_skb && skb_shinfo(st->root_skb)->frag_list) { st->cur_skb = skb_shinfo(st->root_skb)->frag_list; st->frag_idx = 0; goto next_skb; } Actually I did some testing and added a few printks and found that the st->cur_skb->data was 0 and hence the ptr used by iscsi_tcp was null. This caused the kernel panic. if (abs_offset < block_limit) { - *data = st->cur_skb->data + abs_offset; + *data = st->cur_skb->data + (abs_offset - st->stepped_offset); I enabled the debug_tcp and with a few printks found that the code did not go to the next_skb label and could find that the sequence being followed was this - It hit this if condition - if (st->cur_skb->next) { st->cur_skb = st->cur_skb->next; st->frag_idx = 0; goto next_skb; And so, now the st pointer is shifted to the next skb whereas actually it should have hit the second else if first since the data is in the frag_list. else if (st->root_skb == st->cur_skb && skb_shinfo(st->root_skb)->frag_list) { st->cur_skb = skb_shinfo(st->root_skb)->frag_list; goto next_skb; } Reversing the two conditions the attached patch fixes the issue for me on top of Herbert's patches. Signed-off-by: Shyam Iyer <shyam_iyer@dell.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>		16 years ago
..
Makefile	…
datagram.c	…
dev.c	gro: Fix error handling on extremely short frags	16 years ago
dev_mcast.c	…
dst.c	…
ethtool.c	…
fib_rules.c	…
filter.c	…
flow.c	…
gen_estimator.c	…
gen_stats.c	…
iovec.c	…
kmap_skb.h	…
link_watch.c	Revert "net: Fix for initial link state in 2.6.28"	16 years ago
neighbour.c	cpumask: prepare for iterators to only go to nr_cpu_ids/nr_cpumask_bits: net	16 years ago
net-sysfs.c	…
net-sysfs.h	…
net_namespace.c	NET: net_namespace, fix lock imbalance	16 years ago
netevent.c	…
netpoll.c	…
pktgen.c	…
request_sock.c	…
rtnetlink.c	…
scm.c	…
skb_dma_map.c	…
skbuff.c	net: Fix OOPS in skb_seq_read().	16 years ago
sock.c	…
stream.c	…
sysctl_net_core.c	…
user_dma.c	…
utils.c	…