You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Al Viro bf6932f44a iscsi-target: Drop bogus struct file usage for iSCSI/SCTP ... From Al Viro: BTW, speaking of struct file treatment related to sockets - there's this piece of code in iscsi: /* * The SCTP stack needs struct socket->file. */ if ((np->np_network_transport == ISCSI_SCTP_TCP) || (np->np_network_transport == ISCSI_SCTP_UDP)) { if (!new_sock->file) { new_sock->file = kzalloc( sizeof(struct file), GFP_KERNEL); For one thing, as far as I can see it'not true - sctp does *not* depend on socket->file being non-NULL; it does, in one place, check socket->file->f_flags for O_NONBLOCK, but there it treats NULL socket->file as "flag not set". Which is the case here anyway - the fake struct file created in __iscsi_target_login_thread() (and in iscsi_target_setup_login_socket(), with the same excuse) do *not* get that flag set. Moreover, it's a bloody serious violation of a bunch of asserts in VFS; all struct file instances should come from filp_cachep, via get_empty_filp() (or alloc_file(), which is a wrapper for it). FWIW, I'm very tempted to do this and be done with the entire mess: Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Cc: Andy Grover <agrover@redhat.com> Cc: Hannes Reinecke <hare@suse.de> Cc: Christoph Hellwig <hch@lst.de> Cc: stable@vger.kernel.org Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>		13 years ago
..
iscsi	iscsi-target: Drop bogus struct file usage for iSCSI/SCTP	13 years ago
loopback	target: remove transport_generic_process_write	13 years ago
sbp	target: Allow for target_submit_cmd() returning errors	13 years ago
tcm_fc	target: Allow for target_submit_cmd() returning errors	13 years ago
Kconfig	sbp-target: Initial merge of firewire/ieee-1394 target mode support	13 years ago
Makefile	target: move code for CDB emulation	13 years ago
target_core_alua.c	target: Return error to initiator if SET TARGET PORT GROUPS emulation fails	13 years ago
target_core_alua.h	target: Add MI_REPORT_TARGET_PGS ext. header + implict_trans_secs attribute	13 years ago
target_core_configfs.c	Revert "target: Do not special-case loop and iscsi fabric module loads"	13 years ago
target_core_device.c	target: Make unnecessarily global se_dev_align_max_sectors() static	13 years ago
target_core_fabric_configfs.c	target: Remove hba param from core_dev_add_lun	13 years ago
target_core_fabric_lib.c	target: remove useless casts	13 years ago
target_core_file.c	target: move sync_cache to struct spc_ops	13 years ago
target_core_file.h	target/file: Use O_DSYNC by default for FILEIO backends	13 years ago
target_core_hba.c	target: header reshuffle, part2	13 years ago
target_core_iblock.c	target: Check number of unmap descriptors against our limit	13 years ago
target_core_iblock.h	target/iblock: Add parameter to specify read-only devices	13 years ago
target_core_internal.h	target: refactor core_update_device_list_for_node()	13 years ago
target_core_pr.c	target: Remove unneeded double parentheses	13 years ago
target_core_pr.h	target: replace ->execute_task with ->execute_cmd	13 years ago
target_core_pscsi.c	target: add struct spc_ops + initial ->execute_rw pointer usage	13 years ago
target_core_pscsi.h	target: remove struct se_task	13 years ago
target_core_rd.c	target: add struct spc_ops + initial ->execute_rw pointer usage	13 years ago
target_core_rd.h	target: don't limit transfer sizes for the ramdisk backend	13 years ago
target_core_sbc.c	target: move unmap to struct spc_ops	13 years ago
target_core_spc.c	target: Move MAINTENANCE_[IN,OUT] from pscsi_parse_cdb -> spc_parse_cdb	13 years ago
target_core_stat.c	target: remove obvious warnings	13 years ago
target_core_tmr.c	target: replace the processing thread with a TMR work queue	13 years ago
target_core_tpg.c	target: refactor core_update_device_list_for_node()	13 years ago
target_core_transport.c	target: NULL dereference on error path	13 years ago
target_core_ua.c	target: Use array_zalloc for device_list	13 years ago
target_core_ua.h	…