You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Ingo Molnar 83a0944fa9 perf: Enable more compiler warnings ... Related to a shadowed variable bug fix Valdis Kletnieks noticed that perf does not get built with -Wshadow, which could have helped us avoid the bug. So enable -Wshadow and also enable the following warnings on perf builds, in addition to the already enabled -Wall -Wextra -std=gnu99 warnings: -Wcast-align -Wformat=2 -Wshadow -Winit-self -Wpacked -Wredundant-decls -Wstack-protector -Wstrict-aliasing=3 -Wswitch-default -Wswitch-enum -Wno-system-headers -Wundef -Wvolatile-register-var -Wwrite-strings -Wbad-function-cast -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wstrict-prototypes -Wdeclaration-after-statement And change/fix the perf code to build cleanly under GCC 4.3.2. The list of warnings enablement is rather arbitrary: it's based on my (quick) reading of the GCC manpages and trying them on perf. I categorized the warnings based on individually enabling them and looking whether they trigger something in the perf build. If i liked those warnings (i.e. if they trigger for something that arguably could be improved) i enabled the warning. If the warnings seemed to come from language laywers spamming the build with tons of nuisance warnings i generally kept them off. Most of the sign conversion related warnings were in this category. (A second patch enabling some of the sign warnings might be welcome - sign bugs can be nasty.) I also kept warnings that seem to make sense from their manpage description and which produced no actual warnings on our code base. These warnings might still be turned off if they end up being a nuisance. I also left out a few warnings that are not supported in older compilers. [ Note that these changes might break the build on older compilers i did not test, or on non-x86 architectures that produce different warnings, so more testing would be welcome. ] Reported-by: Valdis.Kletnieks@vt.edu Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> LKML-Reference: <new-submission> Signed-off-by: Ingo Molnar <mingo@elte.hu>		16 years ago
..
include	perf report: Adjust column width to the values sampled	16 years ago
PERF-VERSION-GEN	…
abspath.c	perf: Enable more compiler warnings	16 years ago
alias.c	perf_counter tools: Add more warnings and fix/annotate them	16 years ago
cache.h	perf: Enable more compiler warnings	16 years ago
callchain.c	perf: Enable more compiler warnings	16 years ago
callchain.h	perf tools: Factorize the map helpers	16 years ago
color.c	perf: Enable more compiler warnings	16 years ago
color.h	perf: Enable more compiler warnings	16 years ago
config.c	perf: Enable more compiler warnings	16 years ago
ctype.c	perf_counter tools: Add and use isprint()	16 years ago
debug.c	perf tools: Factorize high level dso helpers	16 years ago
debug.h	perf tools: Factorize high level dso helpers	16 years ago
environment.c	…
event.h	perf tools: Add some comments to the event definitions	16 years ago
exec_cmd.c	perf: Enable more compiler warnings	16 years ago
exec_cmd.h	…
generate-cmdlist.sh	…
header.c	perf util: Fix do_read() to fail on EOF instead of busy-looping	16 years ago
header.h	perf: avoid structure size confusion by using a fixed size	16 years ago
help.c	perf_counter tools: Add more warnings and fix/annotate them	16 years ago
help.h	perf_counter tools: Add more warnings and fix/annotate them	16 years ago
levenshtein.c	…
levenshtein.h	…
map.c	perf tools: Factorize the map helpers	16 years ago
module.c	perf: Enable more compiler warnings	16 years ago
module.h	perf_counter tools: Add infrastructure to support loading of kernel module symbols	16 years ago
pager.c	perf_counter tools: Remove dead code	16 years ago
parse-events.c	perf: Enable more compiler warnings	16 years ago
parse-events.h	perf: Enable more compiler warnings	16 years ago
parse-options.c	perf: Enable more compiler warnings	16 years ago
parse-options.h	perf_counter tools: Add new OPT_CALLBACK_DEFAULT option	16 years ago
path.c	perf: Enable more compiler warnings	16 years ago
quote.c	perf: Fix read buffer overflow	16 years ago
quote.h	perf_counter tools: Add more warnings and fix/annotate them	16 years ago
run-command.c	perf: Enable more compiler warnings	16 years ago
run-command.h	perf_counter tools: Remove dead code	16 years ago
sigchain.c	…
sigchain.h	…
strbuf.c	perf_counter tools: Add more warnings and fix/annotate them	16 years ago
strbuf.h	perf_counter tools: Add more warnings and fix/annotate them	16 years ago
string.c	perf_counter tools: Define and use our own u64, s64 etc. definitions	16 years ago
string.h	perf_counter: Detect debugfs location	16 years ago
strlist.c	strlist: Introduce strlist__entry and strlist__nr_entries methods	16 years ago
strlist.h	strlist: Introduce strlist__entry and strlist__nr_entries methods	16 years ago
symbol.c	perf: Enable more compiler warnings	16 years ago
symbol.h	perf: Enable more compiler warnings	16 years ago
thread.c	perf tools: Factorize the thread code in a dedicated file	16 years ago
thread.h	perf tools: Factorize the thread code in a dedicated file	16 years ago
types.h	perf_counter tools: Rework the file format	16 years ago
usage.c	perf top: Fall back to cpu-clock-tick hrtimer sampling if no cycle counter available	16 years ago
util.h	perf tools: Factorize the map helpers	16 years ago
values.c	perf: Enable more compiler warnings	16 years ago
values.h	perf: Enable more compiler warnings	16 years ago
wrapper.c	perf_counter tools: Add more warnings and fix/annotate them	16 years ago